builder-context: Ensure sdk config path resolution stays beneath sdk path#732
Merged
Conversation
swick
reviewed
May 13, 2026
Contributor
swick
left a comment
swick
left a comment
There was a problem hiding this comment.
Looks good in general, only two smaller issues.
bbhtt
force-pushed
the
bbhtt/sdk-config
branch
3 times, most recently
from
47281f0 to
6b6dae5
Compare
swick
reviewed
May 13, 2026
Contributor
swick
left a comment
swick
left a comment
There was a problem hiding this comment.
With that issue fixed, the change LGTM
swick
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.