Skip to content

Update to the very latest nightly version of BlastEm and restrict home directory access - #17

Open
techmetx11 wants to merge 6 commits into
flathub:masterfrom
techmetx11:master
Open

Update to the very latest nightly version of BlastEm and restrict home directory access#17
techmetx11 wants to merge 6 commits into
flathub:masterfrom
techmetx11:master

Conversation

@techmetx11

Copy link
Copy Markdown

This PR updates the BlastEm's source archive to the very last commit made (as of the time of this PR)

Also, the program has been patched to use the XDG Desktop Portal file chooser and enable it by default within the program's settings, which means the program no longer requires read-only access to the user's home directory.

@flathubbot

Copy link
Copy Markdown

🚧 Test build enqueued.

@flathubbot

Copy link
Copy Markdown

🚧 Started test build.

@flathubbot

Copy link
Copy Markdown

Test build failed.

Help
  • bot, build - Restart the test build
  • bot, ping admins - Contact Flathub admins

@flathubbot

Copy link
Copy Markdown

🚧 Test build enqueued.

@flathubbot

Copy link
Copy Markdown

🚧 Started test build.

@flathubbot

Copy link
Copy Markdown

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/252070/com.retrodev.blastem.flatpakref

Built for x86_64 architecture.

⚠️ Linter warnings:

Warnings can be promoted to errors in the future. Please try to resolve them.

  • 'appstream-missing-vcs-browser-url' warning found in linter repo check. Details: Please consider adding a vcs-browser URL to the Metainfo file

@flathubbot

Copy link
Copy Markdown

🚧 Test build enqueued.

@flathubbot

Copy link
Copy Markdown

🚧 Started test build.

@flathubbot

Copy link
Copy Markdown

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/252194/com.retrodev.blastem.flatpakref

Built for x86_64 architecture.

@flathubbot

Copy link
Copy Markdown

🚧 Test build enqueued.

@flathubbot

Copy link
Copy Markdown

🚧 Started test build.

@flathubbot

Copy link
Copy Markdown

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/252240/com.retrodev.blastem.flatpakref

Built for x86_64 architecture.

@techmetx11

Copy link
Copy Markdown
Author

CC @hadess

Comment thread com.retrodev.blastem.json Outdated
Comment thread com.retrodev.blastem.json Outdated
Comment thread com.retrodev.blastem.json Outdated
{
"type": "git",
"url": "https://github.com/flatpak/libportal.git",
"commit": "086cc57372989117cfb6ef4c565bdd316db2e536"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why isn't this a release?

@hadess hadess left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would definitely need to see separate patches (and reordering) for the build fixes, the version update, new dependencies, and applying the file chooser patch.

There's one big problem with this whole patch though, we only get access to the ROM file, and BlastEm expects to be able to access the directory the ROM is in to save the corresponding .SAV file when the game supports saves. This will be broken with this setup. What's the plan for fixing that?

From 464bbad5dea3c481600b206f0bcaa5ace7861650 Mon Sep 17 00:00:00 2001
From: techmetx11 <techmetx11@disroot.org>
Date: Mon, 2 Feb 2026 23:51:58 +0100
Subject: [PATCH] Integrate a native file chooser into BlastEm using XDG

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch is added in this commit, and then modified in a later commit. I'd much rather see a single commit that added the final version of the patch.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to clutter the repository with unnecessary commit files. If you want me to split it all into seperate patch files, then I can do that

Comment thread com.retrodev.blastem.json Outdated
"paths" : [
"0001-Add-support-for-Flatpak-config-data-dir-variables.patch"
"0001-Add-support-for-Flatpak-config-data-dir-variables.patch",
"0002-Integrate-a-native-file-chooser-into-BlastEm-using-X.patch"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That patch is nice, but what's its upstream status? Is the maintainer going to review it/merge it soon? We would at least want a reference in the commit message.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not talked to Michael Pavone yet, besides the patch is a bit messy (in the Makefile, it affects Linux builds in general, not just Flatpak builds)

@flathubbot

Copy link
Copy Markdown

🚧 Test build enqueued.

@flathubbot

Copy link
Copy Markdown

🚧 Started test build.

@flathubbot

Copy link
Copy Markdown

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/260395/com.retrodev.blastem.flatpakref

Built for x86_64 architecture.

@techmetx11

Copy link
Copy Markdown
Author

There's one big problem with this whole patch though, we only get access to the ROM file, and BlastEm expects to be able to access the directory the ROM is in to save the corresponding .SAV file when the game supports saves. This will be broken with this setup. What's the plan for fixing that?

From what I can tell, BlastEm saves game files (if you're talking about EEPROM and SRAM files) in its own directory:

	#path template for saving SRAM, EEPROM and savestates
	#accepts special variables $HOME, $EXEDIR, $USERDATA, $ROMNAME
	save_path $USERDATA/blastem/$ROMNAME	#path template for saving SRAM, EEPROM and savestates
	#accepts special variables $HOME, $EXEDIR, $USERDATA, $ROMNAME
	save_path $USERDATA/blastem/$ROMNAME

Regardless, I'm already planning to patch BlastEm further to fix the screenshot, and VGM/video+audio recording paths (using the XDG user directory paths). If you can point out where it does this, I can also patch that

@flathubbot

Copy link
Copy Markdown

🚧 Test build enqueued.

@flathubbot

Copy link
Copy Markdown

🚧 Started test build.

@flathubbot

Copy link
Copy Markdown

Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/262985/com.retrodev.blastem.flatpakref

Built for x86_64 architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants