Repository navigation
Support Cluster API NTP stanza - #12
Merged
Merged
Conversation
navaneeth-dev
force-pushed
the
feat/ntp-cluster-api
branch
from
October 14, 2026 17:28
3f6f118 to
6af6746
Compare
elmiko
reviewed
Oct 20, 2026
elmiko
left a comment
elmiko
left a comment
Collaborator
There was a problem hiding this comment.
generally looking good to me, i have a couple questions and a suggestion for the tests.
elmiko
reviewed
Oct 22, 2026
elmiko
left a comment
elmiko
left a comment
Collaborator
There was a problem hiding this comment.
updates look good to me, thanks!
i will open an issue to focus on the operating system question.
elmiko
approved these changes
Oct 22, 2026
Collaborator
Author
|
Merging is blocked |
Collaborator
tormath1
approved these changes
Oct 26, 2026
Configure Flatcar's native timesyncd while retaining DHCP-provided sources. Preserve native defaults for disabled NTP or empty server lists, and reject unsupported fields and unsafe server values. Signed-off-by: Navaneeth <me@rizexor.com>
Signed-off-by: Navaneeth <me@rizexor.com>
Convert persistent files through Ignition and runtime files through private base64 tmpfiles rules, with explicitly documented every-boot recreation. Reject unsupported fields, conflicting paths, and oversized runtime rules. Validate defaults, ownership, permissions, and content through Transpile. Verify CLI output on Flatcar 4757.2.1 QEMU through boot and reboot, including replacement, empty files, escaping, and near-limit payloads. Signed-off-by: Navaneeth <me@rizexor.com>
Address review feedback with descriptive NTP subtest names, an explicit-default explanation, and documentation of the Flatcar target and Fedora CoreOS chrony distinction. Signed-off-by: Navaneeth <me@rizexor.com>
Signed-off-by: Navaneeth <me@rizexor.com>
navaneeth-dev
force-pushed
the
feat/ntp-cluster-api
branch
from
October 26, 2026 11:41
50a9ece to
ac4a11d
Compare
Signed-off-by: Navaneeth <me@rizexor.com>
Collaborator
Author
Sorry need reapproval, fixed a CI problem. |
tormath1
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Cluster API’s
ntp.enabledandntp.serversusing Flatcar’s native systemd-timesyncd, keeping DHCP-provided NTP sources allowed alongside configured servers.enabled: falseleaves time synchronization untouched after validation; omitted/null/empty server lists retain Flatcar defaults.