feat: Add regular polygon constructors to PolygonComponent and PolygonHitbox#3891
Merged
spydon merged 7 commits intoflame-engine:mainfrom May 8, 2026
Merged
Conversation
TRI99ERED
changed the title
ufrshubham
requested changes
Apr 6, 2026
Member
ufrshubham
left a comment
ufrshubham
left a comment
There was a problem hiding this comment.
@TRI99ERED please follow the original PR description template. Also, add some tests for this change.
spydon
reviewed
Apr 6, 2026
Member
|
@TRI99ERED will you update this PR? :) |
Contributor
Author
|
Sorry for the delay, some stuff came up. |
spydon
approved these changes
Apr 22, 2026
Member
spydon
left a comment
spydon
left a comment
There was a problem hiding this comment.
Lgtm, thanks for your contribution
ufrshubham
approved these changes
Apr 25, 2026
luanpotter
reviewed
May 1, 2026
| bool? shrinkToBounds, | ||
| }) : this( | ||
| List.generate(sides, (i) { | ||
| final angle = 2 * pi * i / sides; |
Member
|
(I rebased the PR to use my new CI fixes) |
Member
|
@TRI99ERED the tests are failing |
…ve anchor descriptions
…m/TRI99ERED/flame into feat/regular-polygon-constructors
spydon
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds PolygonComponent.regularPolygon and PolygonHitbox.regularPolygon constructors to easily create regular (equiangular and equilateral) polygons by specifying the number of sides and radius.
Usage
`dart
// Create a regular hexagon
PolygonComponent.regularPolygon(6, radius: 100);
// Create a regular octagon hitbox
PolygonHitbox.regularPolygon(8, radius: 50, isSolid: true);
`
Closes #3890