Skip to content

Update .travis.yml#25

Closed
paladox wants to merge 8 commits into
fjakobs:masterfrom
paladox:patch-1
Closed

Update .travis.yml#25
paladox wants to merge 8 commits into
fjakobs:masterfrom
paladox:patch-1

Conversation

@paladox

@paladox paladox commented Oct 25, 2015

Copy link
Copy Markdown

No description provided.

@paladox

paladox commented Oct 25, 2015

Copy link
Copy Markdown
Author

I am not sure how to fix these errors. Could someone fix them please.

@paladox

paladox commented Oct 25, 2015

Copy link
Copy Markdown
Author

It causes other repos that depend on this repo to fail.

@paladox

paladox commented Oct 25, 2015

Copy link
Copy Markdown
Author

Could I have help to fix errors please. I am not sure what to change that code to.

@houli

houli commented Oct 25, 2015

Copy link
Copy Markdown
Contributor

The problem is not with the parts you changed in the calls to Path.exists. The problem is calling Path.exists. This function was marked deprecated because the exists function was moved from the path module to the fs module. In node 0.12 the deprecated function was removed.
One way to make sure this works in old and new versions of node is shown here https://github.com/fjakobs/async.js/blob/master/lib/plugins/fs-node.js#L12
All the places where Path.exists should have been updated when this code was written but clearly the code in the tests wasn't.

@houli

houli commented Oct 25, 2015

Copy link
Copy Markdown
Contributor

I've created a pull request here to fix these tests not passing and to also run CI tests against the latest four versions of node. #27

@paladox

paladox commented Oct 25, 2015

Copy link
Copy Markdown
Author

Thanks.

@fjakobs

fjakobs commented Oct 27, 2015

Copy link
Copy Markdown
Owner

this this PR still needed?

@paladox

paladox commented Oct 27, 2015

Copy link
Copy Markdown
Author

#28

@paladox paladox closed this Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants