[chore][queue-service] ECS 배포 파이프라인 및 인프라 설정 추가#29
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: first-ticket/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deploy.yml:
- Around line 103-109: The ECS deploy step using
aws-actions/amazon-ecs-deploy-task-definition@v2 currently sets
wait-for-service-stability: false which skips post-deployment health
verification; either change the parameter to wait-for-service-stability: true in
the Deploy to ECS step (the aws-actions/amazon-ecs-deploy-task-definition@v2
action with task-definition: task-definition.json, service:
queue-service-service, cluster: first-ticket-cluster) to have the workflow wait
for service stability, or keep it false but add a separate post-deployment
validation job that pings the service / checks ECS task health and fails the
workflow on unhealthy results.
- Around line 33-109: Update the GitHub Actions steps that use older action
versions: change uses: actions/upload-artifact@v5 in the "Upload test report (on
failure)" step to actions/upload-artifact@v7 (current v7.0.1) and change uses:
docker/setup-buildx-action@v3 in the "Set up Docker Buildx" step to
docker/setup-buildx-action@v4 (current v4.0.0); keep the step names ("Upload
test report (on failure)" and "Set up Docker Buildx") and the surrounding YAML
unchanged so only the action version strings are bumped.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: first-ticket/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: dc6b0b89-886e-44e3-b769-4258ce68a660
📒 Files selected for processing (3)
.github/workflows/ci.yml.github/workflows/deploy.ymlsrc/main/resources/application.yml
💤 Files with no reviewable changes (1)
- .github/workflows/ci.yml
- 코드래빗 리뷰 반영 Related to #28
🌱 설명
Queue Service를 AWS ECS에 배포하기 위한 CI/CD 파이프라인 및 인프라 설정을 추가했습니다.
📌 관련 이슈
close #28
💻 커밋 유형
📝 체크리스트
📚 추가 설명
ECS Fargate IP 등록 이슈 사전 방지
ECS Fargate 환경에서는 Spring Cloud의
InetUtils가 컨테이너 IP를 선택할 때 ECS 메타데이터 IP(169.254.172.2, 모든 컨테이너 동일)를 우선 선택하는 경우가 있습니다. 이로 인해 Eureka에 잘못된 IP로 등록되어 다른 서비스가 호출 시 자기 자신을 호출하게 됩니다.이를 방지하기 위해
application.yml에 RFC1918 사설 IP 대역(10.x, 172.x, 192.168.x)을 우선 선택하도록 설정했습니다.CI/CD 통합
기존
ci.yml(빌드/테스트만)을deploy.yml로 통합했습니다.배포 검증 완료
172.31.x.x)로 등록Summary by CodeRabbit