Repository navigation
Look for a source file's address proof in all of its frames - #6407
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6407 +/- ##
==========================================
+ Coverage 84.52% 84.79% +0.26%
==========================================
Files 358 358
Lines 38837 38895 +58
Branches 11001 11023 +22
==========================================
+ Hits 32828 32982 +154
+ Misses 5574 5478 -96
Partials 435 435 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mstange
approved these changes
Oct 21, 2026
findAddressProofForFile took the first func with the file as its source, then that func's first frame, and gave up if that frame had no address. A file can still have other frames with addresses, which the symbolication API would accept just as well. Go through the frames instead and take the first one that has an address and a func with the file as its source. Files that were fetchable but failed now load in the source view and in profiler-cli. The helpers will also be used to find the addresses for all files at once when sharing source code.
canova
force-pushed
the
push-umsoyzvmyvxs
branch
from
October 21, 2026 16:45
d62a093 to
e0b5e5e
Compare
canova
enabled auto-merge
October 21, 2026 16:46
fatadel
added a commit
that referenced
this pull request
Oct 22, 2026
Changes: [Markus Stange] Accept more fields from symbolication. (#6373) [Markus Stange] Support index source maps. (#6399) [fatadel] Make CompositorScreenshot markers schema-based (#6261) [Markus Stange] Use inverted transforms in the tests for inverted call node paths. (#6393) [fatadel] Expose and clear URL-imported call tree search in the CLI (#6387) [Markus Stange] Make the scrollable editor view in the source view cover the full height of the panel, even if the source code is short. (#6405) [Nazım Can Altınova] Silence profile loader logs in profile-querier-url tests (#6409) [Nazım Can Altınova] Add `--js-sources-from-func-names` to `profiler-edit` (#6394) [Nazım Can Altınova] Look for a source file's address proof in all of its frames (#6407) [Markus Stange] Some preparations for a function list panel (#6401) [fatadel] Use fractional seconds with adaptive precision for CLI marker timestamps (#6384) [fatadel] 🔃 Sync: l10n -> main (October 22, 2026) (#6415) [Markus Stange] Switch to TypeScript 7 (tsgo) and replace ESLint with oxlint (#6354) [fatadel] Bump profiler-cli version to 0.12.0 (#6416) And special thanks to our localizers: el: Jim Spentzos uk: Lobodzets, uya2521, Іhor Hordiichuk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
I extracted this from #6404 so it's easier to land.
findAddressProofForFiletook the first func with the file as its source, then that func's first frame, and gave up if that frame had no address. A file can still have other frames with addresses, which the symbolication API would accept just as well. Go through the frames instead and take the first one that has an address and a func with the file as its source.Files that were fetchable but failed now load in the source view and in profiler-cli. The helpers will also be used to find the addresses for all files at once when sharing source code.