Repository navigation
Some preparations for a function list panel - #6401
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6401 +/- ##
==========================================
- Coverage 84.79% 84.78% -0.01%
==========================================
Files 358 358
Lines 38895 38946 +51
Branches 11023 11019 -4
==========================================
+ Hits 32982 33022 +40
- Misses 5478 5488 +10
- Partials 435 436 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
canova
approved these changes
Oct 21, 2026
| const prefix = prefixCol[stackIndex]; | ||
| funcFramePerStack[stackIndex] = | ||
| prefix !== null ? funcFramePerStack[prefix] : -1; | ||
| prefix !== -1 ? funcFramePerStack[prefix] : -1; |
Member
There was a problem hiding this comment.
I think this is squashed to the incorrect commit. It should be squashed to the first one.
The bottom box can currently only be opened for a call node. Add the equivalent lookup for a bare function index, so that views which select functions rather than call nodes can open the bottom box too.
…ative symbols. A function inlined in many places can have tens of thousands of native symbols. Each one cost a pass over the whole stack table plus an assembly fetch, so the daemon appeared to hang.
mstange
force-pushed
the
push-qxxvmrxvwvom
branch
from
October 21, 2026 18:33
1776477 to
7892c63
Compare
mstange
enabled auto-merge
October 21, 2026 18:34
Merged
via the queue into
firefox-devtools:main
with commit Oct 21, 2026
e7a7f8a
21 of 23 checks passed
fatadel
added a commit
that referenced
this pull request
Oct 22, 2026
Changes: [Markus Stange] Accept more fields from symbolication. (#6373) [Markus Stange] Support index source maps. (#6399) [fatadel] Make CompositorScreenshot markers schema-based (#6261) [Markus Stange] Use inverted transforms in the tests for inverted call node paths. (#6393) [fatadel] Expose and clear URL-imported call tree search in the CLI (#6387) [Markus Stange] Make the scrollable editor view in the source view cover the full height of the panel, even if the source code is short. (#6405) [Nazım Can Altınova] Silence profile loader logs in profile-querier-url tests (#6409) [Nazım Can Altınova] Add `--js-sources-from-func-names` to `profiler-edit` (#6394) [Nazım Can Altınova] Look for a source file's address proof in all of its frames (#6407) [Markus Stange] Some preparations for a function list panel (#6401) [fatadel] Use fractional seconds with adaptive precision for CLI marker timestamps (#6384) [fatadel] 🔃 Sync: l10n -> main (October 22, 2026) (#6415) [Markus Stange] Switch to TypeScript 7 (tsgo) and replace ESLint with oxlint (#6354) [fatadel] Bump profiler-cli version to 0.12.0 (#6416) And special thanks to our localizers: el: Jim Spentzos uk: Lobodzets, uya2521, Іhor Hordiichuk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
This adds
getBottomBoxInfoForFunction, which we'll want for a function list panel.This PR also makes a change to profiler-cli behavior with the help of the new support code: When I was using
profiler-clion large libxul binary size profiles,profiler-cli function annotate --mode asmwould sometimes request assembly for thousands of different native symbols and time out. The second patch limits the number of native symbols we show assembly for in the CLI.