-
Notifications
You must be signed in to change notification settings - Fork 189
Hypergeometric2F1 #4943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pbrubeck
wants to merge
9
commits into
main
Choose a base branch
from
pbrubeck/hypergeometric
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hypergeometric2F1 #4943
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bddcba8
Hypergeometric2F1
pbrubeck 2864ea3
test
pbrubeck 52678a3
DROP BEFORE MERGE
pbrubeck 1b736b7
WIP
pbrubeck c4fb8b5
DROP BEFORE MERGE
pbrubeck cbd9b4b
Add another compiler flag
pbrubeck 3176605
empty line
pbrubeck 2f2ba9a
DROP BEFORE MERGE
pbrubeck d69227a
fix libraries
pbrubeck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
tests/firedrake/regression/test_hypergeometric_function.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| from firedrake import * | ||
| from scipy.special import hyp2f1 as sp_hyp2f1 | ||
| import numpy as np | ||
| import pytest | ||
|
|
||
|
|
||
| def test_hypergeometric_function(): | ||
| mesh = UnitDiskMesh(3) | ||
| V = FunctionSpace(mesh, "CG", 1) | ||
| u = Function(V) | ||
| w = Function(V) | ||
| x, y = SpatialCoordinate(mesh) | ||
|
|
||
| expressions = [((1/3, 1/2, 1), Constant(0.9999) * x), | ||
| ((1/2, 1/2, 1), Constant(0.9999) * sqrt(x**2+y**2)), | ||
| ((-1/2, 1/2, 1), Constant(0.4999) * sqrt(x*x + y*y))] | ||
|
|
||
| for (a, b, c), expr in expressions: | ||
| u.interpolate(hyp2f1(a, b, c, expr)) | ||
| result = u.dat.data | ||
| w.interpolate(expr) | ||
| expect = sp_hyp2f1(a, b, c, w.dat.data) | ||
| assert np.allclose(result, expect) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case is giving a different result for arguments >= 0.5 when compared to scipy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is relevant scipy/scipy#8054