[joehan]

Description

Resolves Buganizer b/582886458 (Part of @typescript-eslint/no-floating-promises cleanup, slice 1: src/mcp).

Clears all 36 @typescript-eslint/no-floating-promises warnings under src/mcp without modifying .eslintrc.js (the "warn" override stays in place until remaining directory slices are cleared):

1. src/mcp/index.ts (get logger()):
   • Updated the return type cast of get logger() from Record<LoggingLevel, (message: unknown) => Promise<void>> to Record<LoggingLevel, (message: unknown) => void> to match what logAtLevel actually returns (void). This clears 33 caller-site floating-promise warnings across src/mcp with no behavior change.
   • Replaced the bare and void-prefixed this.server.sendLoggingMessage(...) calls inside get logger() (both in the _pendingMessages flush loop and for live messages) with .catch(() => { ... }) handlers. Small behavior change: a rejected log notification (e.g., when the MCP transport is already closed) is now swallowed instead of becoming an unhandled promise rejection.
2. src/mcp/apps/init/mcp-app.ts & src/mcp/apps/update_environment/mcp-app.ts:
   • Prefixed the top-level browser initialization async IIFEs with void and added comments noting that they catch and report all errors internally (no behavior change).

Scenarios Tested

• npx eslint --config .eslintrc.js --ext .ts,.js src/mcp: 0 errors, 0 @typescript-eslint/no-floating-promises warnings (down from 36).
• npx tsc --noEmit -p tsconfig.json: Passed with 0 errors.
• npm run test:compile: Passed with 0 errors.
• npm run build: Built MCP apps with Vite and compiled TypeScript cleanly.
• npm run lint:quiet: Full-repo ESLint and Prettier checks passed with 0 errors.
• npx mocha 'src/mcp/**/*.spec.ts': 180 passing.
• npm run mocha: 5934 passing (1 pre-existing shared-host port 52672 EADDRINUSE collision in src/apiv2.spec.ts with a proxy).

Sample Commands

N/A (internal typing and lint cleanup)

[gemini-code-assist]

Code Review

This pull request adds error handling to logging messages in FirebaseMcpServer to prevent throwing when the transport is closed, and adds void operators to IIFEs in the MCP apps. The reviewer feedback correctly points out that the newly added comments in the mcp-app.ts files narrate self-evident code, which violates the repository style guide's rule to write high-signal comments explaining 'why' rather than 'what'.

[gemini-code-assist]

This comment narrates self-evident code, which is discouraged by the repository style guide. Comments should focus on explaining why rather than what.

void (async () => {

References

1. Write high-signal comments that explain why, not what. Do not narrate self-evident code. ^(link)

[gemini-code-assist]

This comment narrates self-evident code, which is discouraged by the repository style guide. Comments should focus on explaining why rather than what.

void (async () => {

References

1. Write high-signal comments that explain why, not what. Do not narrate self-evident code. ^(link)