[AI Improvement] [Task] Promote no-fallthrough and no-constant-condition (checkLoops: false) to errors and remove their warn overrides

.eslintrc.js

@@ -14,6 +14,7 @@ module.exports = {
   rules: {
     "jsdoc/newline-after-description": "off",
     "jsdoc/require-jsdoc": ["warn", { publicOnly: true }],
+    "no-constant-condition": ["error", { checkLoops: false }], // Allow intentional `while (true)` and `do ... while (true)` loops.
     "no-restricted-globals": ["error", "name", "length"],
     "prefer-arrow-callback": "error",
     "prettier/prettier": "error",
@@ -67,8 +68,6 @@ module.exports = {
         "@typescript-eslint/prefer-regexp-exec": "warn", // TODO(bkendall): remove, allow to error.
         "@typescript-eslint/restrict-plus-operands": "warn", // TODO(bkendall): remove, allow to error.
         "@typescript-eslint/restrict-template-expressions": "warn", // TODO(bkendall): remove, allow to error.
-        "no-constant-condition": "warn", // TODO(bkendall): remove, allow to error.
-        "no-fallthrough": "warn", // TODO(bkendall): remove, allow to error.
       },
     },
     {

src/deploy/functions/containerCleaner.ts

@@ -20,25 +20,24 @@
   const INITIAL_BACKOFF = 100;
   const TIMEOUT_MS = 10_000;
   let retry = 0;
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     try {
       const timeout = new Promise<Return>((resolve, reject) => {
         setTimeout(() => reject(new Error("Timeout")), TIMEOUT_MS);
       });
       return await Promise.race([func(), timeout]);
     } catch (err: any) {
       logger.debug("Failed docker command with error ", err);
       retry += 1;
       if (retry >= MAX_RETRIES) {
         throw new FirebaseError("Failed to clean up artifacts", { original: err });
       }
       await sleep(Math.pow(INITIAL_BACKOFF, retry - 1));
     }
   }
 }
 
 export async function cleanupBuildImages(
   haveFunctions: backend.Endpoint[],
   deletedFunctions: backend.Endpoint[],
   cleaners: { gcr?: ContainerRegistryCleaner; ar?: ArtifactRegistryCleaner } = {},
@@ -46,7 +45,7 @@
   utils.logBullet(clc.bold(clc.cyan("functions: ")) + "cleaning up build files...");
   const failedDomains: Set<string> = new Set();
   const cleanup: Array<Promise<void>> = [];
   const arCleaner = cleaners.ar || new ArtifactRegistryCleaner();
   // Whether the container was stored in GCR or AR is up to a server-side experiment;
   // clean up both, just in case.
   // TODO: remove GCR path once the experiment is rollack-safe.
@@ -54,7 +53,7 @@
     ...haveFunctions.map(async (func) => {
       try {
         await arCleaner.cleanupFunction(func);
       } catch (err: any) {
         const path = `${func.project}/${func.region}/gcf-artifacts`;
         failedDomains.add(`https://console.cloud.google.com/artifacts/docker/${path}`);
       }
@@ -64,18 +63,18 @@
     ...deletedFunctions.map(async (func) => {
       try {
         await arCleaner.cleanupFunction(func);
       } catch (err: any) {
         const path = `${func.project}/${func.region}/gcf-artifacts`;
         failedDomains.add(`https://console.cloud.google.com/artifacts/docker/${path}`);
       }
     }),
   );
   const gcrCleaner = cleaners.gcr || new ContainerRegistryCleaner();
   cleanup.push(
     ...[...haveFunctions, ...deletedFunctions].map(async (func) => {
       try {
         await gcrCleaner.cleanupFunction(func);
       } catch (err: any) {
         const path = `${func.project}/${docker.GCR_SUBDOMAIN_MAPPING[func.region]}/gcf`;
         failedDomains.add(`https://console.cloud.google.com/gcr/images/${path}`);
       }
@@ -88,7 +87,7 @@
     message +=
       "You can attempt to delete these images by redeploying or you can delete them manually at";
     if (failedDomains.size === 1) {
       message += " " + failedDomains.values().next().value;
     } else {
       message += [...failedDomains].map((domain) => "\n\t" + domain).join("");
     }
@@ -164,7 +163,7 @@
     let op: artifactregistry.Operation;
     try {
       op = await artifactregistry.deletePackage(ArtifactRegistryCleaner.packagePath(func));
     } catch (err: any) {
       // The client was not enrolled in the AR experimenet and the package
       // was missing
       if (err.status === 404) {

src/deploy/functions/runtimes/node/versioning.ts

@@ -38,7 +38,6 @@ export const FUNCTIONS_SDK_VERSION_TOO_OLD_WARNING =
  */
 export function findModuleVersion(name: string, resolvedPath: string): string | undefined {
   let searchPath = path.dirname(resolvedPath);
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     if (searchPath === "/" || path.basename(searchPath) === "node_modules") {
       logger.debug(

src/init/features/hosting/index.ts

@@ -40,8 +40,7 @@ export async function askQuestions(setup: Setup, config: Config, options: Option
       case "nuxt":
       case "nuxt2":
       case "express":
-      // "svelekit" should not be removed unless it's confirmed to not cause breakages.
-      case "svelekit":
+      case "svelekit": // "svelekit" should not be removed unless it's confirmed to not cause breakages.
       case "sveltekit": {
         logger.info();
         const useAppHosting = await confirm({