[AI Improvement] [Task] Remove useless escapes (no-useless-escape), fix three prompt/widget typos, and remove its warn override

.eslintrc.js

@@ -31,7 +31,6 @@ module.exports = {
         ],
       },
     ],
-    "no-useless-escape": "warn", // TODO(bkendall): remove, allow to error.
   },
   overrides: [
     {

scripts/webframeworks-deploy-tests/tests.ts

@@ -21,7 +21,7 @@
 const DEFAULT_LANG = "en";
 const LOG_FILE = "firebase-debug.log";
 const NEXT_SOURCE = `${__dirname}/nextjs`;
-const PATH_SEPARATOR = IS_WINDOWS ? `\\\\` : `\/`;
+const PATH_SEPARATOR = IS_WINDOWS ? `\\\\` : `/`;
 
 async function getFilesListFromDir(dir: string): Promise<string[]> {
   const files = await glob(`${dir}/**/*`, { nodir: true });
@@ -35,12 +35,12 @@
 
   before(async () => {
     expect(FIREBASE_EMULATOR_HUB, "$FIREBASE_EMULATOR_HUB").to.not.be.empty;
     const hubResponse = await fetch(`http://${FIREBASE_EMULATOR_HUB}/emulators`);
     const {
       hosting: { port, host },
     } = await hubResponse.json();
     NEXTJS_HOST = `http://${host}:${port}/${NEXT_BASE_PATH}`.replace(/\/$/, "");
     ANGULAR_HOST = `http://${host}:${port + 5}/${ANGULAR_BASE_PATH}`.replace(/\/$/, "");
   });
 
   after(() => {
@@ -265,14 +265,14 @@
   describe("next.js", () => {
     describe("app directory", () => {
       it("should have working static routes", async () => {
         const apiStaticJSON = JSON.parse(
           readFileSync(
             join(NEXT_OUTPUT_PATH, "hosting", NEXT_BASE_PATH, "app", "api", "static"),
           ).toString(),
         );
         const apiStaticResponse = await fetch(`${NEXTJS_HOST}/app/api/static`);
 
         const jsonResponse = await apiStaticResponse.json();
 
         expect(apiStaticResponse.ok).to.be.true;
 
@@ -447,8 +447,8 @@
       const distDir = ".next";
 
       const UNEXPECTED_PATTERNS = [
-        `${distDir}\/cache\/.*-development`,
-        `${distDir}\/cache\/eslint`,
+        `${distDir}/cache/.*-development`,
+        `${distDir}/cache/eslint`,
       ].map((it) => new RegExp(it));
 
       const files = await getFilesListFromDir(`${NEXT_OUTPUT_PATH}/functions/${distDir}`);
@@ -503,9 +503,9 @@
 
       const EXPECTED_PATTERNS = ["", "en", "fr", "es"]
         .flatMap((locale) => [
-          [I18N_BASE, locale, ANGULAR_BASE_PATH, `main\.[^\.]+\.js`],
-          [I18N_BASE, locale, ANGULAR_BASE_PATH, `polyfills\.[^\.]+\.js`],
-          [I18N_BASE, locale, ANGULAR_BASE_PATH, `styles\.[^\.]+\.css`],
+          [I18N_BASE, locale, ANGULAR_BASE_PATH, `main.[^.]+.js`],
+          [I18N_BASE, locale, ANGULAR_BASE_PATH, `polyfills.[^.]+.js`],
+          [I18N_BASE, locale, ANGULAR_BASE_PATH, `styles.[^.]+.css`],
         ])
         .map((it) => new RegExp(it.filter(Boolean).join(PATH_SEPARATOR)));
 

src/appdistribution/options-parser-util.ts

@@ -36,7 +36,7 @@
 }
 
 // Ensures a the file path that the user input is valid
 export function ensureFileExists(file: string, message = ""): void {
   if (!fs.existsSync(file)) {
     throw new FirebaseError(`File ${file} does not exist: ${message}`);
   }
@@ -188,7 +188,7 @@
   return (value1 && !value2) || (!value1 && value2);
 }
 
-const APP_NAME_REGEX = /^projects\/(?<projectNumber>[^\/]+)\/apps\/(?<appId>[^\/]+)$/;
+const APP_NAME_REGEX = /^projects\/(?<projectNumber>[^/]+)\/apps\/(?<appId>[^/]+)$/;
 const BUCKET_NAME_FORMAT_REGEX = /^[a-z0-9_.-]+$/;
 
 /**

src/apphosting/githubConnections.ts

@@ -39,7 +39,7 @@ interface ConnectionNameParts {
 
 const APPHOSTING_CONN_PATTERN = /.+\/apphosting-github-conn-.+$/;
 const CONNECTION_NAME_REGEX =
-  /^projects\/(?<projectId>[^\/]+)\/locations\/(?<location>[^\/]+)\/connections\/(?<id>[^\/]+)$/;
+  /^projects\/(?<projectId>[^/]+)\/locations\/(?<location>[^/]+)\/connections\/(?<id>[^/]+)$/;
 
 /**
  * Exported for unit testing.

src/dataconnect/names.ts

@@ -8,7 +8,7 @@ interface serviceName {
 }
 
 const serviceNameRegex =
-  /projects\/(?<projectId>[^\/]+)\/locations\/(?<location>[^\/]+)\/services\/(?<serviceId>[^\/]+)/;
+  /projects\/(?<projectId>[^/]+)\/locations\/(?<location>[^/]+)\/services\/(?<serviceId>[^/]+)/;
 
 export function parseServiceName(serviceName: string): serviceName {
   const res = serviceNameRegex.exec(serviceName);
@@ -38,7 +38,7 @@ interface connectorName {
 }
 
 const connectorNameRegex =
-  /projects\/(?<projectId>[^\/]+)\/locations\/(?<location>[^\/]+)\/services\/(?<serviceId>[^\/]+)\/connectors\/(?<connectorId>[^\/]+)/;
+  /projects\/(?<projectId>[^/]+)\/locations\/(?<location>[^/]+)\/services\/(?<serviceId>[^/]+)\/connectors\/(?<connectorId>[^/]+)/;
 
 export function parseConnectorName(connectorName: string): connectorName {
   const res = connectorNameRegex.exec(connectorName);
@@ -69,7 +69,7 @@ interface cloudSQLInstanceName {
 }
 
 const cloudSQLInstanceNameRegex =
-  /projects\/(?<projectId>[^\/]+)\/locations\/(?<location>[^\/]+)\/instances\/(?<instanceId>[^\/]+)/;
+  /projects\/(?<projectId>[^/]+)\/locations\/(?<location>[^/]+)\/instances\/(?<instanceId>[^/]+)/;
 
 export function parseCloudSQLInstanceName(cloudSQLInstanceName: string): cloudSQLInstanceName {
   const res = cloudSQLInstanceNameRegex.exec(cloudSQLInstanceName);

src/dataconnect/schemaMigration.ts

@@ -866,5 +866,5 @@ function diffsToString(diffs: Diff[]): string {
 }
 
 function diffToString(diff: Diff) {
-  return `\/** ${diff.destructive ? clc.red("Destructive: ") : ""}${diff.description}*\/\n${format(diff.sql, { language: "postgresql" })}`;
+  return `/** ${diff.destructive ? clc.red("Destructive: ") : ""}${diff.description}*/\n${format(diff.sql, { language: "postgresql" })}`;
 }

src/deploy/functions/cel.ts

@@ -176,7 +176,7 @@ function preprocessLists(
   params: Record<string, ParamValue>,
 ): CelExpression {
   let rv = expr;
-  const listMatcher = /\[[^\[\]]*\]/g;
+  const listMatcher = /\[[^[\]]*\]/g;
   let match: RegExpMatchArray | null;
   while ((match = listMatcher.exec(expr)) != null) {
     const list = match[0];

src/deploy/functions/runtimes/discovery/v1alpha1.ts

@@ -194,7 +194,7 @@ export function buildFromV1Alpha1(
 }
 
 const ROLE_REGEX =
-  /^(roles\/[a-zA-Z0-9_\.\-]+|projects\/[a-zA-Z0-9\-]+\/roles\/[a-zA-Z0-9_\.\-]+|organizations\/[0-9]+\/roles\/[a-zA-Z0-9_\.\-]+)$/;
+  /^(roles\/[a-zA-Z0-9_.-]+|projects\/[a-zA-Z0-9-]+\/roles\/[a-zA-Z0-9_.-]+|organizations\/[0-9]+\/roles\/[a-zA-Z0-9_.-]+)$/;
 
 function parseRequiredRoles(manifest: WireManifest): string[] {
   const roles: string[] = manifest.requiredRoles || [];

src/deploy/lifecycleHooks.ts

@@ -9,7 +9,7 @@ import { Options } from "../options";
 import { isVSCodeExtension } from "../vsCodeUtils";
 
 function runCommand(command: string, childOptions: childProcess.SpawnOptions) {
-  const escapedCommand = command.replace(/\"/g, '\\"');
+  const escapedCommand = command.replace(/"/g, '\\"');
   const nodeExecutable = isVSCodeExtension() ? "node" : process.execPath;
   const crossEnvShellPath = isVSCodeExtension()
     ? path.resolve(__dirname, "./cross-env/dist/bin/cross-env-shell.js")

src/emulator/auth/server.ts

@@ -395,7 +395,7 @@ export async function createApp(
         `Multiple projectIds are not recommended in single project mode. ` +
         `Requested project ID ${projectId}, but the emulator is configured for ` +
         `${defaultProjectId}. To opt-out of single project mode add/set the ` +
-        `\'"singleProjectMode"\' false' property in the firebase.json emulators config.`;
+        `'"singleProjectMode"' false' property in the firebase.json emulators config.`;
       EmulatorLogger.forEmulator(Emulators.AUTH).log("WARN", errorString);
       if (singleProjectMode === SingleProjectMode.ERROR) {
         throw new BadRequestError(errorString);

src/emulator/auth/widget_ui.spec.ts

@@ -0,0 +1,10 @@
+import { expect } from "chai";
+
+import { WIDGET_UI } from "./widget_ui";
+
+describe("WIDGET_UI", () => {
+  it("should only treat provider IDs with a literal 'saml.' prefix as SAML providers", () => {
+    // The script is built from a template literal, so the source needs `\\.` for the browser to receive `\.`.
+    expect(WIDGET_UI).to.include("providerId.match(/^saml\\./)");
+  });
+});

src/emulator/auth/widget_ui.ts

@@ -34,7 +34,7 @@ var firebaseAppId = query.get('appId');
 var apn = query.get('apn');
 var ibi = query.get('ibi');
 var appIdentifier = apn || ibi;
-var isSamlProvider = !!providerId.match(/^saml\./);
+var isSamlProvider = !!providerId.match(/^saml\\./);
 assert(
   appName || clientId || firebaseAppId || appIdentifier,
   'Missing one of appName / clientId / appId / apn / ibi query params.'

src/emulator/extensions/postinstall.ts

@@ -11,27 +11,27 @@ export function replaceConsoleLinks(postinstall: string): string {
   let subbedPostinstall = postinstall;
   const linkReplacements = new Map<RegExp, string>([
     [
-      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/storage[A-Za-z0-9\/-]*(?=[\)\]\s])/,
+      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/storage[A-Za-z0-9/-]*(?=[)\]\s])/,
       `${uiUrl}${Emulators.STORAGE}`,
     ], // Storage console links
     [
-      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/firestore[A-Za-z0-9\/-]*(?=[\)\]\s])/,
+      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/firestore[A-Za-z0-9/-]*(?=[)\]\s])/,
       `${uiUrl}${Emulators.FIRESTORE}`,
     ], // Firestore console links
     [
-      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/database[A-Za-z0-9\/-]*(?=[\)\]\s])/,
+      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/database[A-Za-z0-9/-]*(?=[)\]\s])/,
       `${uiUrl}${Emulators.DATABASE}`,
     ], // RTDB console links
     [
-      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/authentication[A-Za-z0-9\/-]*(?=[\)\]\s])/,
+      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/authentication[A-Za-z0-9/-]*(?=[)\]\s])/,
       `${uiUrl}${Emulators.AUTH}`,
     ], // Auth console links
     [
-      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/functions[A-Za-z0-9\/-]*(?=[\)\]\s])/,
+      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/functions[A-Za-z0-9/-]*(?=[)\]\s])/,
       `${uiUrl}logs`, // There is no functions page in the UI, so redirect to logs.
     ], // Functions console links
     [
-      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/extensions[A-Za-z0-9\/-]*(?=[\)\]\s])/,
+      /(http[s]?:\/\/)?console\.firebase\.google\.com\/(u\/[0-9]\/)?project\/[A-Za-z0-9-]+\/extensions[A-Za-z0-9/-]*(?=[)\]\s])/,
       `${uiUrl}${Emulators.EXTENSIONS}`,
     ], // Extensions console links
   ]);

src/emulator/functionsEmulator.ts

@@ -191,10 +191,10 @@ interface EmulatedTriggerRecord {
 
 export function createIgnoredFilter(ignore?: string[]): chokidar.Matcher[] {
   const ignored: chokidar.Matcher[] = [
-    /(^|[\/\\])\../, // Ignore hidden files/dirs (covers .dart_tool, .git, etc.)
+    /(^|[/\\])\../, // Ignore hidden files/dirs (covers .dart_tool, .git, etc.)
     /.+\.log/, // Ignore log files
-    /.+?[\\\/]node_modules[\\\/].+?/, // Ignore node_modules
-    /.+?[\\\/]venv[\\\/].+?/, // Ignore venv
+    /.+?[\\/]node_modules[\\/].+?/, // Ignore node_modules
+    /.+?[\\/]venv[\\/].+?/, // Ignore venv
   ];
   if (ignore) {
     const minimatchInstances = ignore.map((pattern) => {
@@ -1948,7 +1948,7 @@ export class FunctionsEmulator implements EmulatorInstance {
     // req.url = /:projectId/:region/:trigger_name/*
     const url = new URL(`${req.protocol}://${req.hostname}${req.url}`);
     let path = `${url.pathname}${url.search}`.replace(
-      new RegExp(`\/${this.args.projectId}\/[^\/]*\/${req.params.trigger_name}\/?`),
+      new RegExp(`/${this.args.projectId}/[^/]*/${req.params.trigger_name}/?`),
       "/",
     );
 

src/emulator/storage/files.ts

@@ -658,6 +658,6 @@ export class StorageLayer {
 /** Returns file separator used in given path, either '\\' or '/'. */
 function getPathSep(decodedPath: string): string {
   // Checks for the first matching file separator
-  const firstSepIndex = decodedPath.search(/[\/|\\\\]/g);
+  const firstSepIndex = decodedPath.search(/[/|\\\\]/g);
   return decodedPath[firstSepIndex];
 }

src/extensions/extensionsHelper.ts

@@ -87,7 +87,7 @@ export const resourceTypeToNiceName: Record<string, string> = {
   "firebaseextensions.v1beta.function": "Cloud Function",
 };
 export type ReleaseStage = "alpha" | "beta" | "rc" | "stable";
-const repoRegex = new RegExp(`^https:\/\/github\.com\/[^\/]+\/[^\/]+$`);
+const repoRegex = new RegExp(`^https://github.com/[^/]+/[^/]+$`);
 const stageOptions = ["rc", "alpha", "beta", "stable"];
 
 /**
@@ -362,7 +362,7 @@ export function validateSpec(spec: any) {
 export async function promptForValidInstanceId(instanceId: string): Promise<string> {
   let instanceIdIsValid = false;
   let newInstanceId = "";
-  const instanceIdRegex = /^[a-z][a-z\d\-]*[a-z\d]$/;
+  const instanceIdRegex = /^[a-z][a-z\d-]*[a-z\d]$/;
   while (!instanceIdIsValid) {
     newInstanceId = await input({
       default: instanceId,

src/extensions/paramHelper.ts

@@ -287,7 +287,7 @@ export function readEnvFile(envPath: string): Record<string, string> {
 }
 
 export function isSystemParam(paramName: string): boolean {
-  const regex = /^firebaseextensions\.[a-zA-Z0-9\.]*\//;
+  const regex = /^firebaseextensions\.[a-zA-Z0-9.]*\//;
   return regex.test(paramName);
 }
 

src/extensions/provisioningHelper.ts

@@ -106,7 +106,7 @@ export function getUsedProducts(spec: ExtensionSpec): DeferredProduct[] {
  * Parses out trigger eventType from the propertiesYaml.
  */
 function getTriggerType(propertiesYaml: string | undefined) {
-  return propertiesYaml?.match(/eventType:\ ([\S]+)/)?.[1];
+  return propertiesYaml?.match(/eventType: ([\S]+)/)?.[1];
 }
 
 async function isStorageProvisioned(projectId: string): Promise<boolean> {

src/firestore/util.ts

@@ -20,15 +20,15 @@ interface FieldName {
 }
 
 // projects/$PROJECT_ID/databases/$DATABASE_ID
-const DATABASE_NAME_REGEX = /projects\/([^\/]+?)\/databases\/([^\/]+)/;
+const DATABASE_NAME_REGEX = /projects\/([^/]+?)\/databases\/([^/]+)/;
 
 // projects/$PROJECT_ID/databases/$DATABASE_ID/collectionGroups/$COLLECTION_GROUP_ID/indexes/$INDEX_ID
 const INDEX_NAME_REGEX =
-  /projects\/([^\/]+?)\/databases\/([^\/]+?)\/collectionGroups\/([^\/]+?)\/indexes\/([^\/]*)/;
+  /projects\/([^/]+?)\/databases\/([^/]+?)\/collectionGroups\/([^/]+?)\/indexes\/([^/]*)/;
 
 // projects/$PROJECT_ID/databases/$DATABASE_ID/collectionGroups/$COLLECTION_GROUP_ID/fields/$FIELD_ID
 const FIELD_NAME_REGEX =
-  /projects\/([^\/]+?)\/databases\/([^\/]+?)\/collectionGroups\/([^\/]+?)\/fields\/([^\/]*)/;
+  /projects\/([^/]+?)\/databases\/([^/]+?)\/collectionGroups\/([^/]+?)\/fields\/([^/]*)/;
 
 /**
  * Parse a Database name into useful pieces.

src/frameworks/angular/utils.ts

@@ -52,7 +52,7 @@ async function localesForTarget(
       for (const [locale, { baseHref }] of Object.entries(i18n.locales)) {
         if (baseHref !== "")
           throw new FirebaseError(
-            `All your i18n locales must have a baseHref of \"\" on Firebase, errored on ${locale}.`,
+            `All your i18n locales must have a baseHref of "" on Firebase, errored on ${locale}.`,
           );
         locales.push(locale);
       }