Repository navigation
Conversation
create-next-on-firebase hasn't been published since May 2024 and gets about 40 downloads a month. Its npm maintainers don't include the account that publishes this repo's packages, so it can't be published anymore. Adding it to unreleasedPackages keeps it in CI builds and tests, while publish runs and release tags skip it.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the scripts/github.js file to add the retired create-next-on-firebase package to the unreleasedPackages list, ensuring it is ignored during releases. There are no review comments, so no additional feedback is provided.
Contributor
Author
|
Closing for now; we're not pursuing this change at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops publishing
create-next-on-firebase. It was last published in May 2024 and gets about 40 downloads a month. Its npm maintainers don't include the account that publishes this repo's packages, so neither the current publish path nor OSS Exit Gate can publish it.This adds it to
unreleasedPackagesinscripts/github.js:create-next-on-firebase-v*release tag fails instead of publishing.Testing
Local dry runs (
npm run publish -- --use-oss-gate --dry-run):@google-cloud/adapter-nextjsandcreate-next-on-firebase.adapter-nextjs-v*→@apphosting/adapter-nextjs,firebase-frameworks-v*→firebase-frameworks.create-next-on-firebase-v*andpackage=create-next-on-firebaseboth fail before anything is staged.