Skip to content

fix(ui_auth): don't call setState in ForgotPasswordView after it is disposed #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BurningAXE wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui_auth): don't call setState in ForgotPasswordView after it is disposed #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/firebase_ui_auth/lib/src/views/forgot_password_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ class _ForgotPasswordViewState extends State<ForgotPasswordView> {
} on fba.FirebaseAuthException catch (e) {
exception = e;
} finally {
setState(() => isLoading = false);
if (mounted) {
setState(() => isLoading = false);
}
}
}

Expand Down
43 changes: 43 additions & 0 deletions packages/firebase_ui_auth/test/views/forgot_password_view_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'dart:async';

import 'package:firebase_auth/firebase_auth.dart' as fba;
import 'package:firebase_ui_auth/firebase_ui_auth.dart';
import 'package:firebase_ui_shared/firebase_ui_shared.dart';
Expand Down Expand Up @@ -95,5 +97,46 @@ void main() {
expect(find.byType(ErrorText), findsNothing);
verify(auth.sendPasswordResetEmail(email: 'delay@email.com')).called(1);
});

testWidgets(
"doesn't call setState if popped while sendPasswordResetEmail is pending",
(tester) async {
final completer = Completer<void>();
when(
auth.sendPasswordResetEmail(email: 'pending@email.com'),
).thenAnswer((_) => completer.future);

await tester.pumpWidget(
MaterialApp(
home: Builder(
builder: (context) => TextButton(
onPressed: () => Navigator.of(context).push(
MaterialPageRoute(
builder: (_) =>
Scaffold(body: ForgotPasswordView(auth: auth)),
),
),
child: const Text('open'),
),
),
),
);
await tester.tap(find.text('open'));
await tester.pumpAndSettle();

await tester.enterText(find.byType(TextField), 'pending@email.com');
await tester.tap(find.byType(LoadingButton));
await tester.pump();

await tester.tap(find.text('Go back'));
await tester.pumpAndSettle();
expect(find.byType(ForgotPasswordView), findsNothing);

completer.complete();
await tester.pump();

expect(tester.takeException(), isNull);
},
);
});
}
Loading