Skip to content

Code Quality: Shared shell helpers between the app and server - #19051

Open
hez2010 wants to merge 6 commits into
files-community:mainfrom
hez2010:feature/server-shared-shell
Open

hez2010 wants to merge 6 commits into
files-community:mainfrom
hez2010:feature/server-shared-shell

Conversation

@hez2010

@hez2010 hez2010 commented Oct 21, 2026

Copy link
Copy Markdown
Member

Shared native shell, image, file identity and drive-label helpers between the app and server.

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-22T14:38:57.219854Z
We couldn’t complete this review. Comment @codex review to try again.
6b5a843 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread src/Files.App.Storage/Windows/Helpers/ShellImage.cs Outdated
Comment thread src/Files.App.Storage/Windows/Helpers/ShellImage.cs Outdated
Comment thread src/Files.Storage/Windows/Shell/ThreadWithMessageQueue.cs
Comment thread src/Files.App.Storage/Windows/Helpers/FileIdentity.cs Outdated
Comment thread Directory.Build.props Outdated
Comment thread src/Files.Storage/Windows/Helpers/ShellImage.cs
Comment thread src/Files.App.Storage/Windows/Helpers/DriveLabel.cs Outdated
Comment thread src/Files.Storage/Windows/Helpers/IconOptions.cs Outdated
Comment thread src/Files.Storage/Windows/Helpers/ShellImage.cs
Comment thread src/Files.App.Storage/Windows/Helpers/ShellImage.cs Outdated
@yair100 yair100 added the ready for review Pull requests that are ready for review label Oct 21, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.


// Events

public static event EventHandler<IEnumerable<WidgetFileTagCardItem>>? SelectedTaggedItemsChanged;

@hez2010 hez2010 Oct 22, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead event, so removed.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@hez2010
hez2010 requested a review from yair100 October 22, 2026 14:42

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants