Repository navigation
Expose per-absorber PML coordinate stretch - #99
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The general FDTD PML previously fixed its peak real coordinate stretch at 2. Add an explicit static
PML(kappa_max=...)setting so boundary studies can select a profile without mutating module globals. The setting reaches the field coefficients, incident columns, exact reflection predictor and prepared identity.The default remains 2. Default job bytes and plan hashes are preserved; existing grazing criteria and numerical tolerances are unchanged. Diagnostics scope the measured stabilizing-loss table to its tested stretch, and the English/Korean guide explains thickness, clearance and decay convergence.
Validation:
cfb9ea12..., rather thanae4479b0.... Unmodified base 83cbc34 produces the identical mismatch in this environment; no golden was changed. The base commit's remote CI is green.No numerical thresholds, goldens or default profile values changed. CUDA was not run locally; required CI remains the integration gate.