Repository navigation
Tests: no Greek on base pdf() devices (green R CMD check --as-cran) - #9
Merged
Merged
Conversation
R CMD check --as-cran sets _R_CHECK_MBCS_CONVERSION_FAILURE_, which turns pdf() conversion warnings into errors. Two tests hit that: - draw_heatmap test: ComplexHeatmap::Heatmap() measures column labels on its own pdf(NULL) before our Symbol-font rewrite runs. Column labels are now ASCII; the Greek legend still exercises the rewrite. - make_rep_heatmap test: the package copy draws plain labels straight onto base pdf(); the Delta is dropped from its label. Assisted-by: AI coding agent
Grepping the binary PDF as text emitted ~100 "unable to translate" warnings with raw stream bytes, on which the CI action's test-output parser crashes (nchar(): invalid multibyte string). Assisted-by: AI coding agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 2 remaining test failures on
mainwhile keepingR CMD check --as-cran.Cause
--as-cransets_R_CHECK_MBCS_CONVERSION_FAILURE_=TRUE, which turnspdf()"conversion failure" warnings into errorspdf()cannot encode Greek; outsideR CMD check --as-cranthis is only a warningexport_plot_standard()already rewrites Greek into Symbol-font spansChanges (tests only)
test-level_labels.Rdraw_heatmap test: ASCII column labels.ComplexHeatmap::Heatmap()measures them on its ownpdf(NULL)before our rewrite runs. The Greek legend still exercises the Symbol-font rewrite.test-make_rep.R: noΔin the label. The package copy ofmake_rep_heatmap()draws plain labels straight onto basepdf(); the app uses its own copy inserver-replicability.R.test-level_labels.Rpage counter:grepl(useBytes = TRUE). Grepping the binary PDF as text emitted ~100 warnings full of raw bytes; the CI action's failure parser then crashed withnchar(): invalid multibyte string.Verified locally (
_R_CHECK_MBCS_CONVERSION_FAILURE_=TRUE, test fileslevel_labels+make_rep): 0 failures, 0 warnings (was 87).The remaining check WARNING (Rd
\usage) is fixed by #7.Prepared with the assistance of an AI coding agent.