Repository navigation
Keep one copy of the 6 session-bound helpers, in R/ (part of #10) - #12
Merged
Merged
Conversation
bucket_add, bucket_remove, bucket_clear, resolve_features (featureBucket, seqAnnoReactive, eds) and make_rep_heatmap, make_rep_dendrogram (input) read per-session state, which is why the server files had their own copies. R/ now holds the app's version of each, and the server files bind it to their scope with the new internal bind_to_scope() instead of redefining it; call sites are unchanged. - bucket_add / resolve_features: the eds-based app versions replace the R/ copies that still used inputDataReactive(); tests mock eds instead - make_rep_heatmap: the app version with rich level-label legends - Guard test: no allowlist left Assisted-by: AI coding agent
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10. Second of two steps, stacked on #11 (base switches to
mainonce #11 is merged). With this, no helper is defined twice any more.Why these 6 were different
bucket_add,bucket_remove,bucket_clear,resolve_featuresreadfeatureBucket,seqAnnoReactive,eds;make_rep_heatmap,make_rep_dendrogramreadinputChanges
R/helperFunctions.Rholds the app's version of all 6: eds-basedbucket_add/resolve_features(theR/copies still usedinputDataReactive()), andmake_rep_heatmapwith rich level-label legends drawn bydraw_heatmap()bind_to_scope(fn, env = parent.frame()): returnsfnwith its free variables resolved in the server scope (the production twin of the tests'with_mock_env())server-featureBucket.R,server-replicability.R: each definition replaced byname <- bind_to_scope(name); the 18 call sites are unchangedresolve_featuresmocks provideedsinstead ofinputDataReactive(); new test for the counts-only fallback (no DE table, so any dataset feature is valid)Behaviour: none for the app; every helper runs the code the app ran before.
Verified locally
test-prolfquapp_h5ad.Rfailures as onmain(local prolfquapp 2.11.1), unrelatedserver-featureBucket.Ris restored (names the 4 bucket helpers), passes after revertingresolve_features,bucket_remove). Browser automation could not trigger those inputs, on unchangedmaineither; covered by the unit testsPrepared with the assistance of an AI coding agent.