Skip to content

Update for DOLFINx v0.11#1173

Open
jhdark wants to merge 15 commits into
festim-dev:mainfrom
jhdark:update_dolfinx_0.11
Open

Update for DOLFINx v0.11#1173
jhdark wants to merge 15 commits into
festim-dev:mainfrom
jhdark:update_dolfinx_0.11

Conversation

@jhdark

@jhdark jhdark commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Description

Summary

Related Issues

Motivation and Context

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔨 Code refactoring (no functional changes, no API changes)
  • 📝 Documentation update
  • ✅ Test update (adding missing tests or correcting existing tests)
  • 🔧 Build/CI configuration change

Testing

  • All existing tests pass locally (pytest)
  • I have added new tests that prove my fix is effective or that my feature works

Code Quality Checklist

  • My code follows the code style of this project (Ruff formatted: ruff format .)
  • My code passes linting checks (ruff check .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Documentation

  • I have updated the documentation accordingly (if applicable)
  • I have added docstrings to new functions/classes following the project conventions

Breaking Changes

Screenshots/Examples

Additional Notes

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.10%. Comparing base (9a6407b) to head (b9a05c5).

Files with missing lines Patch % Lines
src/festim/hydrogen_transport_problem.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
- Coverage   94.76%   93.10%   -1.66%     
==========================================
  Files          46       46              
  Lines        3534     3539       +5     
==========================================
- Hits         3349     3295      -54     
- Misses        185      244      +59     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

J=self.J,
petsc_options=petsc_options,
petsc_options_prefix="festim_solver",
kind="mpi",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgensd I was running into some issues getting the solver to work in a case with a blocked system of 1 block, i.e. when we have a discontinuous case with a single volume. It seems some new logic was added to make things more efficient when possible, and it wouldn't assign block data. Although I found this neat little fix. What do you think?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also stumbled upon the 1-block being not blocked issue when I made irksome, and also added a workaround. I'll have a look at this PR sometime this weekend and see if the fix is the same.

@jhdark jhdark marked this pull request as ready for review July 2, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants