Repository navigation
fix(bench): stabilize benchmark CI workflow, fix SVG overflows, and harmonize docs - #168
Merged
Merged
Conversation
…onize documentation - Remove pull_request auto-commit trigger from wan-benchmark.yml to prevent CI bot from mutating PR branches with noisy burstable VPS runs - Fix wire-format.svg text overflows on Panel A (mask line) and Panel C (epoch ratchet bullets) - Add data fallback in generate-graphs.py and repair pytest test_graphs.py (all 16 tests passing) - Harmonize README, crates/yip-bench/README.md, and social-card to authoritative dataset (23x-138x loss advantage, 10G netns tag)
vxfemboy
temporarily deployed
to
benchmark-approval
October 26, 2026 17:43 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
vxfemboy
temporarily deployed
to
benchmark-approval
October 26, 2026 17:43 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
vxfemboy
temporarily deployed
to
benchmark-approval
October 26, 2026 17:45 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
vxfemboy
temporarily deployed
to
benchmark-approval
October 26, 2026 17:45 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the root causes of volatile/flapping benchmark numbers across PRs, fixes SVG rendering defects, repairs failing benchmark unit tests, and harmonizes documentation with the latest verified dataset:
Stop Benchmark Graph Flapping in CI:
pull_requestauto-commit trigger from.github/workflows/wan-benchmark.yml.t3.smallinstances on every PR and force-pushing transient, fluctuating cloud numbers back to PR branches.workflow_dispatchand scheduled runs for controlled, reproducible testing.Fix SVG Overflows & Formatting Defects:
crates/yip-bench/generate-wire-format.py:⊕ XOR keystream mask: zero magic bytes or fixed wire discriminators.) so it stays cleanly within the 510px card margin instead of breaching out to 520px+.Zeroize on Retireand0% Packet Loss), eliminating a 60px overflow beyond the right border.assets/wire-format.svg.Repair Broken Benchmark Unit Tests:
crates/yip-bench/generate-graphs.py:data=None) so they can be invoked standalone without raisingTypeError.crates/yip-bench/tests/test_graphs.py:pytest crates/yip-bench/tests/now passes 16/16 tests cleanly.Harmonize Documentation & Showcase Assets:
README.md,crates/yip-bench/README.md, andgenerate-social-card.pyto cite the latest verified commit (19a499c):Verification
python3 crates/yip-bench/generate-graphs.py --check: PASSpython3 crates/yip-bench/generate-wire-format.py --check: PASSpytest crates/yip-bench/tests/: 16/16 PASSbash crates/yip-bench/tests/test-generate-graphs.sh: ALL PASSbash crates/yip-bench/tests/test-generate-wire-format.sh: ALL PASScargo fmt --check: PASScargo clippy --workspace --all-targets -- -D warnings: PASScargo shear: PASScargo test --workspace: ALL PASS (443+ tests)