Repository navigation
Pin the autotools host type on Windows - #59
Merged
Merged
Conversation
config.guess reports x86_64-w64-mingw32 inside the MSYS2 MINGW64 shell but x86_64-pc-mingw64 (or -pc-msys) from a plain Windows shell, which is how the desktop release builds. libirecovery only picks its native Windows backend for host_os mingw32*; anywhere else it requires libusb, which MSYS2 no longer packages for MINGW64, so the 0.6.3 Windows desktop build failed at libirecovery's configure. Before that, desktop builds quietly used libirecovery's libusb backend while the CLI used the native one. Pass --build/--host=x86_64-w64-mingw32 so every environment configures the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.6.3 Windows desktop build failed: libirecovery's configure required libusb (run).
libirecovery picks its native Windows backend only when
host_osmatchesmingw32*.config.guessreportsx86_64-w64-mingw32inside the MSYS2 MINGW64 shell, which is where the CLI release and CI build.release-appbuilds from PowerShell instead, where it reportsx86_64-pc-mingw64(x86_64-pc-msysin my VM). That environment fell through to libirecovery's libusb backend. It only worked while MSYS2 still shippedmingw-w64-x86_64-libusb. So until now the Windows desktop app quietly used a different backend from the CLI.This passes
--build/--host=x86_64-w64-mingw32to every autotools configure on Windows, so all environments build the native backend, the one tested in #58.Checked in the Windows VM from plain PowerShell with no
MSYSTEM: libirecovery's configure detectsx86_64-pc-msyswithout the flags andx86_64-w64-mingw32with them. A full coldcargo buildof this branch in that environment is running; I'll note the result here.0.6.3 shipped everything except the Windows desktop installer, and
latest.jsonhas no Windows entry, so the app leaves Windows users on 0.6.2 until the next release.