Repository navigation
Send AppleTCON firmware when the request has no ResponseTags - #57
Merged
Merged
Conversation
A Mac16,5 asks for the AppleTCON updater data without listing any
ResponseTags. Since upstream only adds FirmwareData when that list asks
for it, the Mac got just the Baobab ticket and failed checkpoint 0x1332
("failed to copy response for AppleTCON"). Treat a missing list as
wanting the firmware, like before, and keep the ticket-only reply if the
firmware can't be extracted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a Mac16,5 (M4 Max MacBook Pro) the AppleTCON updater fails during restore with:
The restore still finishes, so it's easy to miss, but the display controller firmware never gets sent.
The Mac's FirmwareUpdaterData request for AppleTCON has no
DeviceGeneratedTags/ResponseTagsat all. It only has MessageArgInfo, MessageArgUpdaterLoopCount, MessageForceRepersonalization and DataChunkSize. Since upstream idevicerestore 3faf292 ("Only send FirmwareData when it has been requested"),restore_get_tcon_firmware_dataonly attaches the firmware when ResponseTags lists FirmwareData. Here it replies with just the Baobab ticket, and the updater gives up. Upstream master hasn't changed this.Patch 0008 treats a request with no ResponseTags as wanting the firmware, the way it worked before that commit. If ResponseTags is present, nothing changes. If the firmware can't be found or extracted, it still sends the ticket-only reply instead of failing the restore.
@freddy-fazbear-real found this while testing #53 and wrote the patch. I only tidied the comment and added it to the patches README. They ran two revives on 27.2.1 (26B131) with it: it extracts
Firmware/DP855/X3091/X3091.bin, sends 1417226 bytes, and the step passes (await_update_appletcon result=0).I checked that it applies on top of the existing patches and builds. I haven't run it on a Mac with a built-in display myself. I don't know whether other models send the request the same way, but any Mac that does was getting ticket-only replies and failing the same checkpoint.