Repository navigation
Better guides for helpers and system extensions - #1
Merged
Merged
Conversation
The check opens files only Full Disk Access can open. With System Integrity Protection's filesystem protection off, every process can open them, so the status, request and the probe all read granted for an app that was never granted anything.
A helper's permissions are usually read over IPC, which forced callers to cache the last answer for a synchronous closure. The check now awaits each call and makes one at a time. Synchronous closures still work.
The panel took both from the bundle being dragged. A helper without an icon got a generic one, and a system extension was named after its file, such as com.example.app.monitor.systemextension.
macOS adds some helpers to a privacy list itself, switched off, once they ask for access. The guide still said to drag an icon in. With alreadyListed it highlights the list and points at the switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four changes that came out of wiring PermissionGuide into an app whose Endpoint Security system extension, not the app, needs Full Disk Access. One commit each.
Changes
Full Disk Access reads
.unknownwhen SIP is off. The check opens TCC.db, which only Full Disk Access can open. On a Mac with System Integrity Protection disabled (seen on macOS 27.2), an app that was never granted anything opens it fine, sostatus,requestand the probe all said granted.currentStatusnow returns.unknownthere, which gives the guide its Done button and stops the probe from being launched for it. Detection iscsr_check(CSR_ALLOW_UNRESTRICTED_FS), a libSystem SPI, weak-imported like the responsibility call the probe already uses.isGrantedcan beasync. A helper's permissions are usually read over IPC, and the synchronous closure forced callers to cache the last answer. The manager now awaits each call and makes one at a time. Synchronous closures still compile unchanged.named:andicon:for the bundle being granted. The panel took both from the dragged bundle, so a.systemextensionshowed a generic icon and its file name.alreadyListed:for privacy panes. macOS adds some helpers to a privacy list itself, switched off. The guide still said "Drag this icon". WithalreadyListed: trueit highlights the list, shows no drag source or ghost, and says to turn on the switch.All three new parameters default to today's behaviour.
Testing
swift build,swift test(6 new tests) and both example packages build.Mode.instructions(subject:), and the existing drag, extension and background-item strings are unchanged, but someone should run the demo before merging.es_new_clientfails. That is what other ES products document. If it doesn't,alreadyListedis still correct for the helpers that do get listed.