Skip to content

Update ruby to 4.0.10 - #99

Merged
fbuys merged 4 commits into
mainfrom
update-ruby
Nov 20, 2026
Merged

fbuys merged 4 commits into
mainfrom
update-ruby

Conversation

@FionaDL

@FionaDL FionaDL commented Nov 20, 2026

Copy link
Copy Markdown
Member

IMPORTANT: please be descriptive and provide all required information. Make sure you provide all the information needed for others to review your PR. On sections marked “if applicable”, if that section is not applicable make sure to delete it. Additionally, if your PR closes any open GitHub issues, make sure you include Closes #XXXX in your comment or use the option on the PR's sidebar to add related issues to auto-close the issue that your PR fixes.

What is this PR:

  • Bug fix
  • Feature
  • Chore
    Update Ruby to 4.0.10

Description:

Please include a summary of the change and which issue is fixed or which feature is introduced. If changes to the behaviour are made, clearly describe what changes.

Screenshots:

If changes to the UI are made, please include screenshots of the before and after.

Related story:

Link to the relevant story in Pivotal Tracker.

Related links (if applicable):

Link to any related issues.

How has this been tested?

  • Automated tests
  • Manual tests

What manual tests have been run?

Describe which manual tests did you run (you can copy paste from the description of the story in Pivotal Tracker) and their outcome (passed or fail). Also add any further details you feel are needed for others to reproduce your results and verify your results.

What browsers did you test it on (if applicable)?

  • Chrome
  • Firefox
  • Edge
  • Safari

What devices did you test it on (if applicable)?

  • Laptop / PC
  • Tablet
  • Mobile

@FionaDL
FionaDL requested review from JuanVqz and arielj November 20, 2026 16:18
FionaDL and others added 3 commits November 20, 2026 11:51
Storage.clearDataForOrigin only matches an exact origin, which includes
the port. The hardcoded "http://127.0.0.1" never matched the random-port
test server, so cookies and localStorage carried over between system
tests. With Capybara's default options, this call is the only thing that
clears them.

- Use Capybara's server base_url as the origin, and skip the call when
  there is no server
- Only apply the patch while Capybara is 3.40.0 or older, so a fixed
  release replaces it automatically
- Move the patch from test_helper.rb to application_system_test_case.rb
  so unit tests don't load Capybara

@fbuys fbuys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review + QA ✅

@fbuys
fbuys merged commit 5cdc472 into main Nov 20, 2026
2 checks passed
@fbuys
fbuys deleted the update-ruby branch November 20, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants