refactor!: move raise_all to IteratorExt::raise - #56
Open
tisonkun wants to merge 3 commits into
Open
Conversation
Replace the associated constructor with a fluent iterator extension while preserving child order, empty-iterator behavior, and caller locations.
tisonkun
marked this pull request as ready for review
August 9, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IteratorExt::raise(parent)for iterators whose items convert intoExn.Exn::raise_allentry point with the iterator extension.Why
raiseThe fluent forms now read symmetrically:
The iterator receiver already expresses plurality, so
raise_allrepeats information.collect_allwould suggest collectingResultvalues and deciding how successes and failures interact.This intentionally does not revive the fail-slow
Iterator<Item = Result<T, E>>design from #32. That is a separate collection operation, comparable to error-stack'stry_collect_reports.Compatibility
This is a breaking API change, recorded in the changelog. The draft keeps one policy question visible for review: remove
Exn::raise_alldirectly for the next release, as implemented here, or deprecate it for one release first.Validation
cargo test --workspacecargo +nightly clippy --tests --all-features --all-targets --workspace -- -D warningscargo +nightly fmt --all --checktaplo format --checkon tracked TOML filestyposhawkeye check