fix(workflows): add Nix access-tokens for private GitHub flake inputs#10
Open
nikzen wants to merge 2 commits into
Open
fix(workflows): add Nix access-tokens for private GitHub flake inputs#10nikzen wants to merge 2 commits into
nikzen wants to merge 2 commits into
Conversation
mkNixGitAuthStep only configured git URL rewriting, which does not affect Nix's tarball fetcher. Nix fetches GitHub flake inputs as tarballs via the GitHub API, not via git, so private repos returned HTTP 404 despite the token being available. Append access-tokens to /etc/nix/nix.conf and restart the daemon so Nix can authenticate tarball downloads from private repositories. Made-with: Cursor
The shared deny.toml template contains exceptions for all Famedly AGPL crates, but not every project depends on all of them. cargo-deny fails on unmatched exceptions by default. Add unused-license-exception = "allow" so projects using this template don't fail when they only depend on a subset of Famedly crates. Also add famedly-operator to the AGPL exception list. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mkNixGitAuthSteponly configured git URL rewriting (git config --system url...insteadOf), which does not affect Nix's tarball fetcherapi.github.com/repos/.../tarball/...), not via git — so private repos returned HTTP 404 despite theENGINEERING_STANDARDS_READtoken being availableaccess-tokens = github.com=<token>to/etc/nix/nix.confand restarts the Nix daemon so it can authenticate tarball downloads from private repositoriesTest plan
engineering-standardsas a private flake input can successfully runnix flake checkin CIMade with Cursor