fix(reusable-burndown): declare JF_CI_GH_PAT in workflow_call secrets#305
Merged
Conversation
secrets.JF_CI_GH_PAT was used in 4 container credential blocks but was not declared in on.workflow_call.secrets, causing GitHub Actions to reject the workflow with a validation error. All callers (nightly-burndown.yml in every repo) fail with 'workflow file issue'. Add JF_CI_GH_PAT as optional so callers can pass secrets: inherit and fall back to GITHUB_TOKEN when the PAT is absent. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
secrets.JF_CI_GH_PATis referenced in 4 container credential blocks but not declared inon.workflow_call.secrets. GitHub validates reusable workflow secrets at parse time, so callers (e.g.nightly-burndown.yml) fail with 'workflow file issue'.Fix
Add
JF_CI_GH_PAT: required: falseto the secrets block.actionlintpasses cleanly after this change.