Repository navigation
Conversation
Summary: The `Python Linting` workflow has failed on every pull request since `et_replay/pyproject.toml` changed its `package-dir` from `.` to `et_replay` (facebookresearch#210). That value is right for meta-pytorch/chakra_replay, where `pyproject.toml` sits at the repository root above the `et_replay/` package. In this repository `pyproject.toml` lives inside the package directory, so `pip install et_replay/` fails with `error: package directory 'et_replay' does not exist`. - Install et_replay from a copy staged in the chakra_replay layout, rather than changing `pyproject.toml`, which chakra_replay also uses. - Import `ExecutionTrace` from `et_replay.execution_trace`. The same change emptied the package `__init__.py`, so `from et_replay import ExecutionTrace` no longer works. Differential Revision: D127034812
meta-cla
Bot
added
the
CLA Signed
|
@sunguobao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127034812. |
|
This pull request has been merged in 985ae34. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
Python Lintingworkflow has failed on every pull request sinceet_replay/pyproject.tomlchanged itspackage-dirfrom.toet_replay(#210). That value is right for meta-pytorch/chakra_replay, wherepyproject.tomlsits at the repository root above theet_replay/package. In this repositorypyproject.tomllives inside the package directory, sopip install et_replay/fails witherror: package directory 'et_replay' does not exist.pyproject.toml, which chakra_replay also uses.ExecutionTracefromet_replay.execution_trace. The same change emptied the package__init__.py, sofrom et_replay import ExecutionTraceno longer works.Differential Revision: D127034812