Skip to content

Remove external consumers of TorchComms rccl and rcclx (#224) #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunguobao wants to merge 1 commit into from
Closed

Remove external consumers of TorchComms rccl and rcclx (#224) #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion train/comms/pt/pytorch_backend_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class CollectiveArgsMixin:

supportedDevices = ["cpu", "cuda", "rocm", "tpu"]
supportedC10dBackends = ["nccl", "gloo", "mpi", "ucc", "xla", "mccl"]
supportedTorchcommsBackends = ["rcclx", "ncclx", "rccl", "mccl"]
supportedTorchcommsBackends = ["ncclx", "mccl"]
supportedCollectives = [
"reduce",
"all_reduce",
Expand Down
7 changes: 6 additions & 1 deletion train/comms/pt/pytorch_torchcomms_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

logger = logging.getLogger(__name__)

_VALID_BACKENDS = ["nccl", "ncclx", "rcclx", "mccl"]
_VALID_BACKENDS = ["nccl", "ncclx", "mccl"]


class PyTorchTorchcommsBackend(backendFunctions):
Expand Down Expand Up @@ -742,6 +742,11 @@ def initialize_backend(
self, master_ip, master_port, backend="ncclx", eager_mode=False
):
"""Initialize the torchcomms backend"""
if torch.version.hip is not None:
raise ValueError(
"The pytorch-torchcomms stack does not support AMD GPUs. "
"Use --nw-stack pytorch-dist for AMD benchmarks."
)
if backend not in _VALID_BACKENDS:
raise ValueError(
f"Invalid backend {backend}. Valid backends are {_VALID_BACKENDS}"
Expand Down
Loading