Remove stale preconditioner config names from __init__.py#256
Open
runame wants to merge 1 commit intofacebookresearch:mainfrom
Open
Remove stale preconditioner config names from __init__.py#256runame wants to merge 1 commit intofacebookresearch:mainfrom
__init__.py#256runame wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
`AmortizedPreconditionerConfig` was renamed to `BaseShampooPreconditionerConfig` and `ShampooPreconditionerConfig` to `ClassicShampooPreconditionerConfig` in `shampoo_types.py`, but `__init__.py` still imported and re-exported the old names. Replace them with the new names in the imports and `__all__`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
meta-cla
bot
added
the
CLA Signed
wz337
approved these changes
Apr 15, 2026
|
@hjmshi has imported this pull request. If you are a Meta employee, you can view this in D101275252. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shampoo_types.pyrenamedAmortizedPreconditionerConfig→BaseShampooPreconditionerConfigandShampooPreconditionerConfig→ClassicShampooPreconditionerConfig(cb150a9), butdistributed_shampoo/__init__.pystill imported and re-exported the old names, soimport distributed_shampoofails at HEAD withImportError.__all__entries.Test plan
python -c "import distributed_shampoo"succeedsdistributed_shampoo.BaseShampooPreconditionerConfiganddistributed_shampoo.ClassicShampooPreconditionerConfigare accessible__all__resolves to an actual module attributeClassic→Base,RootInv→Classic,Eigendecomposed→Classic,EigenvalueCorrected→Base)