fix: avoid deprecated class-scoped fixture instance method - #2746
Open
RblxDev-ALS wants to merge 1 commit into
Open
RblxDev-ALS wants to merge 1 commit into
RblxDev-ALS wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make TestProphetCopy.data a static method because it does not use instance state. This removes the class-scoped instance-method fixture warning introduced in pytest 9.1 and avoids the planned pytest 10 incompatibility without changing fixture scope or data.
Validated on Windows with Python 3.14.5 and pytest 9.1.1 against this checkout's Python source, using the unchanged Stan model's compiled runtime from the Prophet 1.4.0 wheel:
python -m pytest prophet/tests/test_diagnostics.py -q -W error::pytest.PytestRemovedIn10Warning— 27 passed, no warnings.A fresh source build and the full test suite were not run locally.