Skip to content

fix(AppShell): keep the sticky header above field inputs - #5693

Open
Cypher-Aura-19 wants to merge 1 commit into
facebook:mainfrom
Cypher-Aura-19:fix/5689-appshell-header-stacking
Open

fix(AppShell): keep the sticky header above field inputs#5693
Cypher-Aura-19 wants to merge 1 commit into
facebook:mainfrom
Cypher-Aura-19:fix/5689-appshell-header-stacking

Conversation

@Cypher-Aura-19

@Cypher-Aura-19 Cypher-Aura-19 commented Aug 30, 2026

Copy link
Copy Markdown

Summary

  • restore the sticky AppShell header's stacking level so regular page content cannot paint above it while scrolling
  • add regression coverage for Field inputs under an auto-height AppShell header

The header had been lowered to the same stacking level used by Field input wrappers, allowing detached and tooltip Field variants to paint over it.

Testing

  • targeted AppShell, Field, TextArea, and TextInput tests
  • core typecheck
  • ESLint
  • changeset/use-client/sync checks
  • verified the stacking behavior in Chromium with Storybook + Playwright

Fixes #5689

@vercel

vercel Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 30, 2026 3:10pm

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 30, 2026
@github-actions github-actions Bot added community Authored by a community contributor (not on the eng/design team) needs:code-review High-risk change (new package/component/API) — needs human code review before merge needs:design-review Affects visuals — Design should review labels Aug 30, 2026
@Cypher-Aura-19
Cypher-Aura-19 marked this pull request as ready for review August 30, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubyycheung rubyycheung rubyycheung approved these changes
@cvkxx cvkxx Awaiting requested review from cvkxx
@ernestt ernestt Awaiting requested review from ernestt
@kentonquatman kentonquatman Awaiting requested review from kentonquatman
@cixzhang cixzhang Awaiting requested review from cixzhang cixzhang is a code owner
@imdreamrunner imdreamrunner Awaiting requested review from imdreamrunner imdreamrunner is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot. community Authored by a community contributor (not on the eng/design team) needs:code-review High-risk change (new package/component/API) — needs human code review before merge needs:design-review Affects visuals — Design should review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Field inputs can paint above the sticky AppShell header

2 participants

@Cypher-Aura-19 @rubyycheung