Skip to content

fix(all): pass defaults for DefaultValue fields to ctors - #5267

Merged
MangelMaxime merged 4 commits into
mainfrom
fix/default-value-ctor-args
Nov 5, 2026
Merged

MangelMaxime merged 4 commits into
mainfrom
fix/default-value-ctor-args

Conversation

@MangelMaxime

Copy link
Copy Markdown
Member

F# leaves [<DefaultValue>] fields out of an explicit constructor's { ... } expression, so the generated constructor got one argument per missing field too few: shifted fields on JS, TS2554 on TS, a missing argument on Python, and "The lists had different lengths" on Rust and Beam.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Python Type Checking Results (Pyright)

Metric Value
Total errors 33
Files with errors 4
Excluded files 4
New errors ✅ No
Excluded files with errors (4 files)

These files have known type errors and are excluded from CI. Remove from pyrightconfig.ci.json as errors are fixed.

File Errors Status
temp/tests/Python/test_hash_set.py 18 Excluded
temp/tests/Python/test_applicative.py 11 Excluded
temp/tests/Python/test_nested_and_recursive_pattern.py 2 Excluded
temp/tests/Python/fable_modules/thoth_json_python/encode.py 2 Excluded

@MangelMaxime
MangelMaxime marked this pull request as ready for review November 5, 2026 16:34
@MangelMaxime
MangelMaxime merged commit cc94c9c into main Nov 5, 2026
44 checks passed
@MangelMaxime
MangelMaxime deleted the fix/default-value-ctor-args branch November 5, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant