Repository navigation
fix(all): recompile dependents on signature change in watch - #5084
Merged
Merged
Conversation
Contributor
Python Type Checking Results (Pyright)
|
| File | Errors | Status |
|---|---|---|
temp/tests/Python/fable_modules/thoth_json_core/codec.py |
2 |
Excluded files with errors (4 files)
These files have known type errors and are excluded from CI. Remove from pyrightconfig.ci.json as errors are fixed.
| File | Errors | Status |
|---|---|---|
temp/tests/Python/test_hash_set.py |
18 | Excluded |
temp/tests/Python/test_applicative.py |
12 | Excluded |
temp/tests/Python/test_nested_and_recursive_pattern.py |
2 | Excluded |
temp/tests/Python/fable_modules/thoth_json_python/encode.py |
2 | Excluded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction (Fable 5.21)
Two files,
Lib.fsthenMain.fs:Run
dotnet fable --watch.Main.jscontainsnew R(1, "x").Edit only
Lib.fs: swap the fields to{ B: string; A: int }. Save.Fable recompiles
Lib.fsonly.Main.jsstill containsnew R(1, "x")while the constructor now expects(B, A), so at runtimer.Bis1andr.Ais"x". A freshdotnet fablegives the correctnew R("x", 1).The same steps with other edits to
Lib.fsleaveMain.jsstale in the same way: changing an enum case value or a[<Literal>]used inMain.fskeeps the old constant, and changing a function's return type keeps the oldstring xreplacement. IfMain.fsalso happens to call a method ofLib.fs, the overload suffix registers a dependency for the whole file and everything comes out right, which is why this stayed hidden.Measurements
Watch cycles on
tests/Js/Main, before vs after:Util/Util.fsUtil/Util.fs