Skip to content

fix(python): use the .NET range for Decimal.MaxValue and Decimal.MinValue #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MangelMaxime merged 1 commit into from
Sep 12, 2026
Merged

fix(python): use the .NET range for Decimal.MaxValue and Decimal.MinValue #4967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/fable-library-py/fable_library/decimal_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from decimal import MAX_EMAX, MIN_EMIN, Decimal, getcontext
from decimal import Decimal, getcontext

from .core import Array, FSharpRef, array, byte, float32, float64, int16, int64, sbyte, uint16, uint32, uint64
from .types import IntegerTypes
Expand All @@ -10,8 +10,8 @@
get_one = Decimal(1)

get_minus_one = Decimal(-1)
get_max_value = MAX_EMAX
get_min_value = MIN_EMIN
get_max_value = Decimal("79228162514264337593543950335")
get_min_value = Decimal("-79228162514264337593543950335")


def compare(x: Decimal, y: Decimal) -> int:
Expand Down
4 changes: 2 additions & 2 deletions tests/Python/TestArithmetic.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,8 @@ let ``test Decimal literals can be generated`` () =
0M |> equal Decimal.Zero
1M |> equal Decimal.One
-1M |> equal Decimal.MinusOne
// FIXME: 79228162514264337593543950335M |> equal Decimal.MaxValue
// FIXME: -79228162514264337593543950335M |> equal Decimal.MinValue
79228162514264337593543950335M |> equal Decimal.MaxValue
-79228162514264337593543950335M |> equal Decimal.MinValue

[<Fact>]
let ``test Decimal.ToString works`` () =
Expand Down
Loading