Skip to content

fix(python): accept allowAccessToPrivateRepresentation in FSharpType.IsUnion/IsRecord/GetUnionCases #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MangelMaxime merged 1 commit into from
Jul 5, 2026
Merged

fix(python): accept allowAccessToPrivateRepresentation in FSharpType.IsUnion/IsRecord/GetUnionCases #4722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Fable.Transforms/Python/Replacements.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4004,7 +4004,16 @@ let fsharpType com methName (r: SourceLocation option) t (i: CallInfo) (args: Ex
| "IsRecord"
| "IsTuple"
| "IsFunction" ->
Helper.LibCall(com, "Reflection", Naming.lowerFirst methName, t, args, i.SignatureArgTypes, ?loc = r)
// Drop the trailing `allowAccessToPrivateRepresentation` flag (no meaning in Python)
Helper.LibCall(
com,
"Reflection",
Naming.lowerFirst methName,
t,
List.truncate 1 args,
i.SignatureArgTypes,
?loc = r
)
|> Some
| "IsExceptionRepresentation"
| "GetExceptionFields" -> None // TODO!!!
Expand Down
4 changes: 3 additions & 1 deletion tests/Python/TestReflection.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ let ``test reflection functions accept allowAccessToPrivateRepresentation`` () =
let recordType = typeof<MyRecord>
let record = { String = "a"; Int = 1 }

FSharpType.IsRecord(recordType, allowAccessToPrivateRepresentation = true) |> equal true
FSharpType.GetRecordFields(recordType, allowAccessToPrivateRepresentation = true).Length |> equal 2

let values = FSharpValue.GetRecordFields(record, allowAccessToPrivateRepresentation = true)
Expand All @@ -231,7 +232,8 @@ let ``test reflection functions accept allowAccessToPrivateRepresentation`` () =
rebuilt |> equal record

let unionType = typeof<MyUnion>
let intCase = FSharpType.GetUnionCases(unionType).[1]
FSharpType.IsUnion(unionType, allowAccessToPrivateRepresentation = true) |> equal true
let intCase = FSharpType.GetUnionCases(unionType, allowAccessToPrivateRepresentation = true).[1]
let u = FSharpValue.MakeUnion(intCase, [| box 5 |], allowAccessToPrivateRepresentation = true) :?> MyUnion
let info, fields = FSharpValue.GetUnionFields(u, unionType, allowAccessToPrivateRepresentation = true)
info.Name |> equal "IntCase"
Expand Down
Loading