fix: Use pointers for integer fields in GTM, LTM, and Sys structs to support explicit zero values - #131
Open
waltzbucks wants to merge 1 commit into
Open
fix: Use pointers for integer fields in GTM, LTM, and Sys structs to support explicit zero values#131waltzbucks wants to merge 1 commit into
waltzbucks wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue where integer fields with a value of 0 were being omitted from JSON payloads sent to the BIG-IP API
due to the omitempty struct tag. This behavior caused problems in newer BIG-IP versions where default values for certain fields
(like GTM pool member ratio) have changed from 0 to 1. By changing these fields from int to *int, the SDK can now distinguish
between a missing value (nil) and an explicit zero (0), ensuring the intended configuration is applied.
Problem
In recent BIG-IP versions (e.g., 11.6.1 HF1+), the default value for GTM pool member ratio changed to 1. When a user explicitly
set ratio = 0:
This issue also affected other fields such as member_order, QoS settings, and LTM node/member ratios.
Changes
Impact
Related Issue
(#130) Change GTM Pool Member Ratio to *int to support explicit 0 values