fix: show clear message when widget hits token budget (429) - #53
Open
VedantPatel04 wants to merge 1 commit into
Open
fix: show clear message when widget hits token budget (429)#53VedantPatel04 wants to merge 1 commit into
VedantPatel04 wants to merge 1 commit into
Conversation
Skip the non-streaming fallback on ConversationTokenBudgetExceeded and tell users to start a new chat instead of a misleading retry prompt. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
Hi, FE layer should be stateless as much as can, who handling the error should be BE and FE only parsing it or maybe detailed it with human read able string. GENERIC ERROR should be only if we got error not known but here we should upstream dedicated error |
AmitAvital1
requested changes
Jul 26, 2026
AmitAvital1
left a comment
AmitAvital1
left a comment
Collaborator
There was a problem hiding this comment.
BTW As i said some other already opened PR so you can work in parallel but you can just pick other issue :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the non-streaming fallback on ConversationTokenBudgetExceeded and tell users to start a new chat instead of the "Something went wrong" message displayying.
Tested using
make checkas well, run is clean.Closes #50