fix(orchestrator): load both system and orchestrator prompt files - #52
Merged
AmitAvital1 merged 2 commits intoJul 27, 2026
Merged
Conversation
rishu685
force-pushed
the
fix/issue-38-orchestrator-prompts
branch
from
July 26, 2026 05:30
81e2561 to
a137e00
Compare
AmitAvital1
reviewed
Jul 26, 2026
AmitAvital1
requested changes
Jul 26, 2026
AmitAvital1
left a comment
AmitAvital1
left a comment
Collaborator
There was a problem hiding this comment.
small comment and can be approved
nice fast work 🚀
orchestrator is the required routing prompt. system is the optional persona prefix prepended when present. When orchestrator is absent, fall back to description for backward compatibility. Closes extra-org#38
rishu685
force-pushed
the
fix/issue-38-orchestrator-prompts
branch
from
July 26, 2026 16:37
a137e00 to
8b1eec5
Compare
Contributor
Author
|
Done made the required changes! |
AmitAvital1
reviewed
Jul 26, 2026
AmitAvital1
reviewed
Jul 26, 2026
AmitAvital1
reviewed
Jul 27, 2026
rishu685
force-pushed
the
fix/issue-38-orchestrator-prompts
branch
from
July 27, 2026 06:05
e205684 to
3097b0b
Compare
Always join system and orchestrator prompts directly without an conditional check, satisfying the reviewer feedback. Closes extra-org#38
rishu685
force-pushed
the
fix/issue-38-orchestrator-prompts
branch
from
July 27, 2026 06:30
3097b0b to
677cca2
Compare
AmitAvital1
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OrchestratorNode.__call__was previously only readingself._spec.prompts.system, silently dropping the orchestrator prompt file (self._spec.prompts.orchestrator). This meant routing instructions configured inorchestrator.mdwere never sent to the LLM, causing the orchestrator to lose its routing context.What was changed
OrchestratorNode.__call__insrc/agent_engine/engine/langgraph/nodes.pyto load*bothsystemandorchestratorprompt files and combine them.descriptionas a last-resort fallback when neither prompt file is configured, preserving backward compatibility.test_orchestrator_loads_both_promptsintests/engine/test_engine_flow.pycovering all four possible configurations:Anyusingcast(Any, ...)to satisfy strict type-checking checks.Verification Results
533 passed(including the new test cases).All checks passed!Success: no issues found in 167 source files.Related Issue