ci: add quality gate workflow running make check and make validate (#23) - #34
Merged
Merged
Conversation
Two unused imports, two overlong lines, and a missing dict annotation that mypy flagged — all present on main before this branch; fixed here so the new CI workflow passes on its own PR.
pydantic refuses typing.TypedDict on Python < 3.12, so FastMCP's schema generation crashed the example MCP server at startup on CI's 3.11 (passed locally on 3.13). Caught by the new CI's first run.
Asaf-prog
approved these changes
Jul 20, 2026
Collaborator
|
Please, the pipeline did not trigger automatically. Please fix it. |
Contributor
Author
|
Hi @Asaf-prog — I looked into it. The workflow itself is fine (it ran and passed on several PRs this week, e.g. #39 and #41). The runs that didn't start — like #42 right now — are stuck in Two options (maintainer-only):
One thing I'd advise against: switching the trigger to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23.
Adds
.github/workflows/ci.ymlrunningmake check(ruff + mypy + pytest) andmake validate(offline validation of the flagship example) on every pull request and on pushes tomain.Per the issue's non-goals: single Python version as pinned in
pyproject.toml(3.11), no version matrix, no caching tuning beyond pip cache insetup-python. Aconcurrencygroup cancels superseded runs of the same branch to save runner minutes.Also includes a small cleanup commit fixing 5 pre-existing lint/mypy errors that were already on
main(two unused imports, two overlong lines, one missing type annotation) — without it, the new CI would be red on its own PR.Making the
checkjob a required status check via branch protection onmainremains a maintainer action (repo settings), as noted in the issue.