[build-tools] Limit simulator recording bitrate - #4325
Open
szdziedzic wants to merge 2 commits into
Open
Conversation
|
✅ Thank you for adding the changelog entry! |
gwdp
approved these changes
Aug 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4325 +/- ##
==========================================
+ Coverage 65.38% 65.39% +0.01%
==========================================
Files 1058 1058
Lines 49090 49094 +4
Branches 10353 10353
==========================================
+ Hits 32095 32099 +4
Misses 16879 16879
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sjchmiela
approved these changes
Sep 1, 2026
Comment on lines
+19
to
+20
| // A two-hour recording at this target is about 4.5 GB, leaving room below R2's | ||
| // single-part upload limit for MP4 container overhead. |
Contributor
There was a problem hiding this comment.
this feels very handwavy cause if the screen does not change, a two hour recording should be under 10 MB
| }); | ||
| } | ||
|
|
||
| export function createRecordSimArgs({ |
Contributor
There was a problem hiding this comment.
i don't think extracting to a separate function makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
iOS Simulator recordings currently inherit
record-sim's 30 Mbps default. Long device run sessions can therefore produce multi-gigabyte artifacts that approach or exceed the single-part upload limit.Companion WWW change: https://github.com/expo/universe/pull/30668
How
Pass an explicit 5 Mbps bitrate for device run session recordings. A two-hour recording at that target is about 4.5 GB before MP4 container overhead, leaving headroom below the 4.995 GiB R2 limit while retaining a reasonable H.264 screen-recording bitrate. The standalone
record-simdefault is unchanged.Test Plan
CI