Move the community links into a config file - #468
Closed
bbassie wants to merge 1 commit into
Closed
Conversation
The five links were locale strings repeated in every language. They are now exp_legacy/config/links.lua, read by the readme and the join message, and the [links] locale sections are gone. The selection mode messages are also tidied: the lawnmower said it would fill the area with water, repair and blueprint clearing had a generic message, and artillery had a typo in its exit message. Fixes explosivegaming#424
Member
|
This overlaps with #455 so only one of these two will be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #424.
The five community links were locale strings repeated in every language. They are now
exp_legacy/config/links.lua, read by the readme's external links table and the join greeting, and the[links]sections are removed from all three locales.For the selection mode messages I kept per command keys, since each carries its own hint, but fixed the wording where it was wrong or empty: the lawnmower said it would fill the area with water, repair and blueprint clearing had a generic "select the area", and artillery had "Existed" for exited. If you would rather have one shared section in exp_util's selection module with the command name as a parameter, say so and I will follow up.
Lua lint is clean, and on my dev instance the config loads and the readme resolves the links from it.