Use page and slot for quick bar filters - #466
Merged
Merged
Conversation
Factorio 2.1 changed get_quick_bar_slot and set_quick_bar_slot to take a page and slot rather than a single index, and to describe slots holding records, remotes and specific item instances. Saved filters keep their single index, which is converted on load and save, and only plain item filters are saved since the other slot types hold data which has no name to store. The command is enabled again. Fixes explosivegaming#444
Cooldude2606
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #444.
Factorio 2.1 changed
get_quick_bar_slotandset_quick_bar_slotto take a page and slot instead of a single index, and to return aQuickBarSlotdescribing records, remotes, filters and item instances. The saved filters keep their single 1 to 100 index (the presets inconfig/preset_player_quickbar.luastill work unchanged); load converts it to page and slot, and save iterates the ten pages of ten slots. Only slots of typefilterare saved, since records, remotes and specific item instances hold data which has no item name to store, which replaces the old hard coded ignore list. The/save-quickbarcommand is enabled again and the placeholder error is gone.Lua lint is clean; the scenario loads on my dev instance and the command is registered. Saving needs a player with a quick bar, so I could not exercise it headless.