Repository navigation
Upgrade MailKit to 5.0 - #2725
Merged
Merged
Conversation
MailKit 5 drops BouncyCastle and depends on MimeKit.Core, which no longer pulls in System.Security.Cryptography.Pkcs, so remove the Pkcs pin that covered MimeKit's vulnerable 10.0.0 range. The SendAsync(MimeMessage) overload moved to an extension method in the MailKit namespace.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade MailKit from 4.18.2 to 5.0.0, a major release that drops BouncyCastle and moves to
MimeKit.Core.MailKit4.18.2 → 5.0.0using MailKit;toMailKitMailSenderSmtpClient.SendAsync(MimeMessage)is now an extension method in theMailKitnamespace (porting guide §2.1). Its return value changed toSendResult; we ignore it.System.Security.Cryptography.Pkcs11.0.0 pinMimeKit.Core5 doesn't depend on Pkcs at all, and Pkcs is gone from the restore graph.We only send HTML mail over SMTP, so none of the IMAP, S/MIME, DKIM, mock, or 64-bit size changes in the porting guide apply.
Behavior changes that still compile and might matter:
\r\n. We don't parse them.mailkit.net.*metrics report more specificerror.typevalues. We don't collect those meters.Validation:
dotnet list package --vulnerable --include-transitiveis clean.MailKitMailSenderto the local Mailpit. It arrived with the HTML body and theX-Mailer-Machine,Auto-Submitted, andX-Auto-Response-Suppressheaders intact.MailKitMailSender(tests useNullMailer), so CI here mainly confirms the build.