Repository navigation
Complete .NET 11 OpenAPI and duration follow-up - #2724
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
niemyjski
force-pushed
the
feature/dotnet-11
branch
from
November 12, 2026 00:02
d7a0791 to
32c0b3c
Compare
niemyjski
force-pushed
the
feature/dotnet-11
branch
from
November 12, 2026 00:04
32c0b3c to
56a1078
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main now includes the .NET 11 upgrade from #2665. This PR completes the remaining follow-up: use ASP.NET Core's OpenAPI 3.2 default, regenerate client models, preserve exact session duration precision, and strengthen credential-response regression coverage. Docker and dependency versions now match main; the Node installation change has been removed.
Validation: 231 focused backend/API tests passed; main's unchanged 11 session tests passed with the duration fix; frontend validation passed. Fresh PR CI passed: all four backend shards, frontend, all six browser shards and aggregate checks, and Docker. Publishing/deployment were skipped.
Compatibility: the published document moves from OpenAPI 3.1.2 to 3.2.0. The repository's client generator succeeds without changing its implementation; endpoint and schema content is otherwise unchanged.
Verification and implementation details
4a62c42b3. Its existing 11 session tests pass, but the new exact-duration regression fails: expected123.4567891, actual123.45678909999999461888364749. Decimal tick division avoids the intermediate double; persisted-double assertions remain unchanged from main./private/tmpbecause the broad word assertion matches stack-trace paths. Assert the actual synthetic private payloads instead; all affected assistant tests pass.authentication_versionalready exists in main's server model and OpenAPI schema. The generated client was stale. Organization-add returns a fresh email-only User, not the stored record; the strengthened endpoint test seeds private fields and verifies they are not returned, passing on main and this branch. Ordinary user endpoints map to ViewUser/ViewCurrentUser, which exclude credential fields.-mt1.69s → 1.28s; clean builds were noisy. No global build-mode change.