Skip to content

Complete .NET 11 OpenAPI and duration follow-up - #2724

Merged
niemyjski merged 3 commits into
mainfrom
feature/dotnet-11
Nov 12, 2026
Merged

niemyjski merged 3 commits into
mainfrom
feature/dotnet-11

Conversation

@niemyjski

@niemyjski niemyjski commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Main now includes the .NET 11 upgrade from #2665. This PR completes the remaining follow-up: use ASP.NET Core's OpenAPI 3.2 default, regenerate client models, preserve exact session duration precision, and strengthen credential-response regression coverage. Docker and dependency versions now match main; the Node installation change has been removed.

Validation: 231 focused backend/API tests passed; main's unchanged 11 session tests passed with the duration fix; frontend validation passed. Fresh PR CI passed: all four backend shards, frontend, all six browser shards and aggregate checks, and Docker. Publishing/deployment were skipped.

Compatibility: the published document moves from OpenAPI 3.1.2 to 3.2.0. The repository's client generator succeeds without changing its implementation; endpoint and schema content is otherwise unchanged.

Verification and implementation details
  • Baseline: current main 4a62c42b3. Its existing 11 session tests pass, but the new exact-duration regression fails: expected 123.4567891, actual 123.45678909999999461888364749. Decimal tick division avoids the intermediate double; persisted-double assertions remain unchanged from main.
  • Main's eight provider-shape privacy tests fail in a checkout under /private/tmp because the broad word assertion matches stack-trace paths. Assert the actual synthetic private payloads instead; all affected assistant tests pass.
  • authentication_version already exists in main's server model and OpenAPI schema. The generated client was stale. Organization-add returns a fresh email-only User, not the stored record; the strengthened endpoint test seeds private fields and verifies they are not returned, passing on main and this branch. Ordinary user endpoints map to ViewUser/ViewCurrentUser, which exclude credential fields.
  • OpenAPI 3.2 generation and all four contract tests pass. The generated models differ only by the previously missing authentication-version property; runtime response behavior is unchanged.
  • Strict maintainability review: no added production branches, abstractions, or file crossings above 1,000 lines. Removed the redundant session-test rewrite and all overlapping dependency/build changes.
  • A later local session rerun encountered an orphaned test index occupying an alias name. The same failure reproduced on main; removing that disposable index restored all 11 passing tests.
  • Earlier performance measurements remain historical .NET 10/11 observations, not new gains versus current main: incremental median 2.08s → 1.65s; optional -mt 1.69s → 1.28s; clean builds were noisy. No global build-mode change.
  • Manual workflow run 43124492698 was canceled before publishing after inspection showed its publishing condition was broader than intended; no deployment was requested.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T00:05:58.302025Z 56a1078 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@niemyjski niemyjski changed the title Upgrade to .NET 11 Complete .NET 11 OpenAPI and duration follow-up Nov 12, 2026
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.AppHost 23% 22% 130 ❌
Exceptionless.Core 78% 70% 11007 ✔
Exceptionless.Insulation 51% 43% 370 ➖
Exceptionless.Web 86% 72% 9415 ✔
Summary 81% (28637 / 35506) 70% (14323 / 20508) 20922 ✔

@niemyjski
niemyjski merged commit 9454612 into main Nov 12, 2026
22 checks passed
@niemyjski
niemyjski deleted the feature/dotnet-11 branch November 12, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant