Repository navigation
Let users grant every scope to self-registered OAuth clients - #2721
Merged
Merged
Conversation
MCP clients request every scope discovery advertises, but a dynamically registered client was stored without stacks:write. Consent rejected the whole request with invalid_scope, so the client could never be approved. A self-registered client chooses its own scopes and could register again with all of them, so that list restricts nothing. Those clients may now request any supported scope, and the user's consent limits the grant. Scopes an administrator saved stay enforced: consent offers only the allowed ones and the final authorization request is still strict.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 190f6d7528
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A metadata refresh overwrote an administrator's saved settings and reset UpdatedByUserId, which made the application count as self-registered and lifted its scope restriction. Skip the refresh once an administrator has saved the application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP clients can't connect: approving access fails with "Unable to load application details" and Approve stays disabled. The real response is
invalid_scope. Refs #2615.Cause
flowchart LR A[Discovery advertises 6 scopes] --> B[Client requests all 6] C[Registration stores 5, no stacks:write] --> D{Consent check} B --> D D -->|before| E[invalid_scope, cannot approve] D -->|after| F[User approves, grant limited by consent]#2638 made the error readable but left enforcement unchanged, so main still blocks approval.
Behavior
stacks:write.Review notes
Verification
v8.10.0(hotfix base)