docs: UI foundation documentation set (specs, ADRs, skills, agent instructions) - #116
Open
evertonschuster wants to merge 1 commit into
Open
docs: UI foundation documentation set (specs, ADRs, skills, agent instructions)#116evertonschuster wants to merge 1 commit into
evertonschuster wants to merge 1 commit into
Conversation
Every markdown file this feature branch (002-ui-foundation) changes relative to main, split into its own PR so it can be reviewed on its own track, separately from the admin-frontend code in #115: - New skill workflows: .claude/skills/agenza-{a11y-review,api-contract, frontend-slice,ptbr-copy,tenant-isolation,testing,ui-primitive}/ - Agent instruction files: root and admin-frontend AGENTS.md/CLAUDE.md, .github/copilot-instructions.md - New ADRs: 0039 (Base UI primitives), 0040 (three-state theme), 0041 (AI instruction files reinstated) and docs/adr/README.md's index - The 002-ui-foundation feature's spec, plan, tasks and acceptance checklist - Updated apps/admin-frontend/docs/ARCHITECTURE.md and .specify/memory/constitution.md - Root and admin-frontend README.md No code changes. The ADRs, spec and tasks describe the admin-frontend UI foundation that #115 implements — until that PR also merges, main will have documentation for a feature whose code isn't there yet, which is an accepted, temporary tradeoff for reviewing docs and code on separate tracks. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (36)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
evertonschuster
added a commit
that referenced
this pull request
Sep 7, 2026
Same change as 002-ui-foundation@a4fce93, synced here to keep this code-only PR (#117) current with what #115 already carries — no markdown, per this branch's own split from #116. - Six destination pages and the new ProtectedAppShell (composes ProtectedRoute + AppShell) become react-router's native `lazy: () => import(...)` routes instead of static imports. - LoginPage/AuthCallbackPage stay eager: they share @/features/auth's barrel with useAuth, already imported without lazy elsewhere, so a dynamic import there can't isolate them into their own chunk (confirmed by Rollup's INEFFECTIVE_DYNAMIC_IMPORT warning). - HydrateFallback on the root route is a <main> wrapping a real <h1>, not a bare <div> — the first version tripped 3 axe violations (landmark-one-main, page-has-heading-one, region) during the brief window it's on screen before the first route's chunk resolves, caught by the real e2e a11y suite in CI (not reproducible in the unit-test harness, which scans an isolated container rather than the full document). Entry chunk: 646 kB -> 348 kB (-46%). Full suite (tsc/eslint/prettier/ vitest+coverage/build) green; coverage unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Por quê
Split fora da PR #115 — que traz o código
da UI foundation do admin-frontend — para que os 36 arquivos .md que essa branch muda possam
ser revisados no próprio ritmo, sem competir com a leitura do diff de código.
Nenhum arquivo de código muda nesta PR.
O que entra
.claude/skills/agenza-{a11y-review,api-contract,frontend-slice,ptbr-copy,tenant-isolation,testing,ui-primitive}/**AGENTS.mdeCLAUDE.md(raiz eapps/admin-frontend/),.github/copilot-instructions.mddocs/adr/README.mdapps/admin-frontend/specs/002-ui-foundation/{spec,plan,tasks}.md+checklists/acceptance.mdapps/admin-frontend/docs/ARCHITECTURE.md,apps/admin-frontend/.specify/memory/constitution.mdapps/admin-frontend/Trade-off aceito
As ADRs e a spec descrevem a fundação de UI que a #115 implementa em código. Se esta PR mergear
primeiro, a
mainfica temporariamente com documentação de uma feature cujo código ainda nãoestá lá — até a #115 também mergear. Aceito deliberadamente para permitir revisão em faixas
separadas.
🤖 Generated with Claude Code