create_periods_t: bugfix, make last period same length as others - #33
Merged
Conversation
The join in fit_partial_models() and fit_full_models() kept every row of trans_preds_nested, so restricting trans_meta had no effect and non-viable transitions could still be fitted with NA lulc ids. Make it an inner join. Regression from e5df256. Direct-learner mode has carried the no.crossval sentinel in crossval_score since 39ea13a, so that predict_trans_pot() can rank the model; the tests and the roxygen block still claimed it would be empty. Regenerate R/sysdata.rda so test_periods_t reflects the create_periods_t fix (its last period was still one day long), and guard the fixture against future drift, since data-raw/ does not run during checks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011DgJshsVtPMqdw7Ni7oKba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Periods need to be of equal length; now decided to err on the side of "create a last full period that may go beyond the specified
end_extrapolated"