fix: Add missing 'let' declaration in createEOF1Code function#1494
Open
reallesee wants to merge 1 commit intoethereum:developfrom
Open
fix: Add missing 'let' declaration in createEOF1Code function#1494reallesee wants to merge 1 commit intoethereum:developfrom
reallesee wants to merge 1 commit intoethereum:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a potential scope issue in EOF1-generator.js by adding a proper 'let' declaration for the 'eof1' variable in the createEOF1Code function. This prevents the variable from becoming an implicit global, which could cause unexpected behavior when the function is called multiple times. The change improves code reliability and follows JavaScript best practices without altering functionality