web: subtly band grouped ranges in the tracer instruction list#265
Closed
gnidan wants to merge 2 commits into
Closed
web: subtly band grouped ranges in the tracer instruction list#265gnidan wants to merge 2 commits into
gnidan wants to merge 2 commits into
Conversation
Add quiet grouped-range highlighting to the instruction list, coexisting with the call badges from #262. Consecutive instructions belonging to one group get a faint background band and a light label; a small control in the panel header switches the grouping: - function: coarse bands per enclosing activation, labeled with the function name (pairs with the call badges, which mark entry/return); - source: finer bands per source statement/expression, labeled with the source line; - off: today's flat list. Presentation only — grouped from the same source ranges and invoke/return contexts already used for the highlight and call-info banner. No indentation, collapsing, or sticky headers.
Contributor
|
Source-range group labels can be a whole function definition (~100 chars). Truncate to one line with an ellipsis and expose the full text via a title tooltip, and cap the label at the panel width so a long source line can't widen the drawer or wrap.
Member
Author
|
Setting the banding aside for now — the grouped-range presentation needs a clearer sense of what information to surface before it's worth building. The call badges (#262) cover the immediate need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #262 (call badges). Adds the subtle grouped-range highlighting from the design exploration — quiet bands + light labels so you can see where instructions group, coexisting with the call badges.
➜ call/↵ returnbadges mark where it's entered/returned.Presentation only — grouped from the same source ranges and invoke/return contexts already used for the source highlight and call-info banner. Best seen on the deploy preview: open any example with a call (e.g. "Function call and return") and flip the grouping control.